CanDo

Merge lp:~aelkner/cando/filter_widget_bug into lp:~vcs-imports/cando/trunk

  1. filter_widget_bug
  2. Merge into trunk
Proposed by Alan Elkner
Status: Needs review
Proposed branch: lp:~aelkner/cando/filter_widget_bug
Merge into: lp:~vcs-imports/cando/trunk
Diff against target: 24 lines (+3/-1)
2 files modified
CHANGES.txt (+1/-0)
src/cando/newskin/person.py (+2/-1)
To merge this branch: bzr merge lp:~aelkner/cando/filter_widget_bug
Reviewer Review Type Date Requested Status
Justas Sadzevičius (community) Approve
VCS imports Pending
Review via email: mp+39345@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Justas Sadzevičius (justas.sadzevicius) wrote :

Ouch. Yes, that definitely needs fixin.

review: Approve
Reply

Unmerged revisions

1052. By Alan Elkner <aelkner@ubuntu>

Fixed person filter widget bug where groups drop-down was empty

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CHANGES.txt'
2--- CHANGES.txt 2010-08-23 03:33:55 +0000
3+++ CHANGES.txt 2010-10-26 07:43:44 +0000
4@@ -8,6 +8,7 @@
5 - Renamed menu option to 'Import Competencies from CSV' and updated
6 the instructions and example in the 'Import Competencies from a CSV
7 file' form
8+- Fixed person filter widget bug where groups drop-down was empty
9
10
11 2010.06.2 (2010-07-15)
12
13=== modified file 'src/cando/newskin/person.py'
14--- src/cando/newskin/person.py 2009-01-09 07:37:58 +0000
15+++ src/cando/newskin/person.py 2010-10-26 07:43:44 +0000
16@@ -35,7 +35,8 @@
17
18 def groups(self):
19 groups = []
20- for id, group in IGroupContainer(ISchoolToolApplication, {}).items():
21+ container = IGroupContainer(ISchoolToolApplication(None), {})
22+ for id, group in container.items():
23 groups.append({'id': id, 'title': "%s" % group.title})
24 return groups
25

Subscribers

People subscribed via source and target branches

to all changes: