Merge ~adrien/ubuntu/+source/mpi4py:plucky-merge-4.0.1-6 into ubuntu/+source/mpi4py:debian/sid

Proposed by Adrien Nader
Status: Merged
Merge reported by: Adrien Nader
Merged at revision: 28653254247577e3aa2a44d63ad4011ae7f3cbf8
Proposed branch: ~adrien/ubuntu/+source/mpi4py:plucky-merge-4.0.1-6
Merge into: ubuntu/+source/mpi4py:debian/sid
Diff against target: 104 lines (+58/-1)
4 files modified
debian/changelog (+27/-0)
debian/control (+2/-1)
debian/patches/series (+1/-0)
debian/patches/skip_failing_tests_32bit_mpich.patch (+28/-0)
Reviewer Review Type Date Requested Status
Sudip Mukherjee (community) Approve
Ubuntu Sponsors Pending
Review via email: mp+477902@code.launchpad.net

This proposal supersedes a proposal from 2024-11-29.

Description of the change

Merge from Debian. Chances are that will fix a test triggered by openmpi and help with the transition.

I've dropped changes that are not needed anymore: as far as I understand, they only applied during build but not during autopkgtest unfortunately. I wasn't able to test in a PPA due to infra issues (pulling from a PPA is broken everywhere at the moment) but the tests passed at build-time, including on armhf and s390x.

It's possible that we could sync the package instead but without the ability to test in PPA, I went for a middle-ground that seemed enough and safe.

To post a comment you must log in.
Revision history for this message
Sudip Mukherjee (sudipmuk) wrote :

uploaded

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index bb6e43a..97bbe24 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+mpi4py (4.0.1-6ubuntu1) plucky; urgency=medium
7+
8+ * Merge with Debian; remaining changes:
9+ - Restore test_pack skipping in skip_failing_tests_32bit_mpich.patch
10+
11+ -- Adrien Nader <adrien.nader@canonical.com> Fri, 29 Nov 2024 17:44:01 +0100
12+
13 mpi4py (4.0.1-6) unstable; urgency=medium
14
15 * mips64el is in trouble. Reinstate version restriction. Test
16@@ -29,6 +36,20 @@ mpi4py (4.0.1-4) unstable; urgency=medium
17
18 -- Drew Parsons <dparsons@debian.org> Mon, 18 Nov 2024 23:37:00 +0100
19
20+mpi4py (4.0.1-3ubuntu2) plucky; urgency=medium
21+
22+ * No-change rebuild for openmpi soname change.
23+
24+ -- Matthias Klose <doko@ubuntu.com> Sat, 30 Nov 2024 07:13:34 +0100
25+
26+mpi4py (4.0.1-3ubuntu1) plucky; urgency=medium
27+
28+ * Merge with Debian; remaining changes:
29+ - Restore test_pack skipping in skip_failing_tests_32bit_mpich.patch
30+ * Add armhf and s390x to the list of architectures to ignore test results.
31+
32+ -- Matthias Klose <doko@ubuntu.com> Mon, 18 Nov 2024 09:22:46 +0100
33+
34 mpi4py (4.0.1-3) unstable; urgency=medium
35
36 * s390x ppc64: skip testConnectAccept too
37@@ -145,6 +166,12 @@ mpi4py (4.0.0-1exp1) experimental; urgency=medium
38
39 -- Drew Parsons <dparsons@debian.org> Mon, 29 Jul 2024 23:49:55 +0200
40
41+mpi4py (3.1.6-9ubuntu1) oracular; urgency=medium
42+
43+ * Restore test_pack skipping in skip_failing_tests_32bit_mpich.patch
44+
45+ -- Graham Inggs <ginggs@ubuntu.com> Thu, 05 Sep 2024 10:51:28 +0000
46+
47 mpi4py (3.1.6-9) unstable; urgency=medium
48
49 * debian patch mpich_32bit_13e8af6.patch applies upstream commit
50diff --git a/debian/control b/debian/control
51index e17bc3b..aeefcf6 100644
52--- a/debian/control
53+++ b/debian/control
54@@ -1,5 +1,6 @@
55 Source: mpi4py
56-Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
57+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
58+XSBC-Original-Maintainer: Debian Science Maintainers <debian-science-maintainers@lists.alioth.debian.org>
59 Uploaders: Drew Parsons <dparsons@debian.org>,
60 Yaroslav Halchenko <debian@onerussian.com>,
61 Michael Hanke <michael.hanke@gmail.com>,
62diff --git a/debian/patches/series b/debian/patches/series
63index 11a257d..f9a8105 100644
64--- a/debian/patches/series
65+++ b/debian/patches/series
66@@ -2,3 +2,4 @@ intersphinx_use_local_inventory.patch
67 skip_ppc_failing_tests.patch
68 skip_s390x_failing_tests.patch
69 skip_testPackUnpackExternal_sparc64.patch
70+skip_failing_tests_32bit_mpich.patch
71diff --git a/debian/patches/skip_failing_tests_32bit_mpich.patch b/debian/patches/skip_failing_tests_32bit_mpich.patch
72new file mode 100644
73index 0000000..6264554
74--- /dev/null
75+++ b/debian/patches/skip_failing_tests_32bit_mpich.patch
76@@ -0,0 +1,28 @@
77+--- a/test/test_pack.py
78++++ b/test/test_pack.py
79+@@ -90,6 +90,7 @@ class BaseTestPackExternal:
80+ self.assertGreaterEqual(real_size, 0)
81+
82+ @unittest.skipMPI("openmpi(<5.0)", platform.machine() == 'sparc64')
83++ @unittest.skipMPI("mpich", platform.architecture()[0] == '32bit')
84+ def testPackUnpackExternal(self):
85+ for array, typecode1 in arrayimpl.loop():
86+ with arrayimpl.test(self):
87+--- a/test/test_spawn.py
88++++ b/test/test_spawn.py
89+@@ -1,6 +1,7 @@
90+ from mpi4py import MPI
91+ import mpiunittest as unittest
92+ import sys, os, mpi4py
93++import platform
94+
95+ import platform
96+
97+@@ -93,6 +94,7 @@ def skip_spawn():
98+ @unittest.skipMPI('openmpi(>=5.0.0,<5.1.0)', skip_spawn())
99+ @unittest.skipMPI('mpich(<4.1.0)', appnum() is None)
100+ @unittest.skipMPI('mpich(<4.3.0)', badport())
101++@unittest.skipMPI("mpich", platform.architecture()[0] == '32bit')
102+ @unittest.skipMPI('msmpi(<8.1.0)')
103+ @unittest.skipMPI('msmpi', skip_spawn())
104+ @unittest.skipMPI('msmpi', appnum() is None)

Subscribers

People subscribed via source and target branches