Merge ~adrien/ubuntu/+source/gnutls28:autopkgtests-fixes-with-system-config into ubuntu/+source/gnutls28:ubuntu/devel

Proposed by Adrien Nader
Status: Superseded
Proposed branch: ~adrien/ubuntu/+source/gnutls28:autopkgtests-fixes-with-system-config
Merge into: ubuntu/+source/gnutls28:ubuntu/devel
Diff against target: 27 lines (+7/-1)
2 files modified
debian/changelog (+6/-0)
debian/tests/run-upstream-testsuite (+1/-1)
Reviewer Review Type Date Requested Status
Ubuntu Sponsors Pending
git-ubuntu import Pending
Review via email: mp+455751@code.launchpad.net

This proposal has been superseded by a proposal from 2023-11-17.

Description of the change

The gnutls testsuite is influenced by the configuration stored in /etc/gnutls/config. This means that the package build and tests succeeded until the most recent version of the package landed in -proposed because tests then started being run with the new package and the new configuration that it ships.

This merge request makes the testsuite pass by skipping a few tests for stuff that is now disabled and by stripping a few mentions of TLS 1.0 and 1.1 since they're now disabled. A better long-term approach is maybe to make the testsuite run without the influence of any configuration file and re-enable tests related to the configuration file (they are disabled but I'm not sure why at the moment; this might come from Debian).

I opened a bug report upstream in order to find out if the testsuite is supposed to be run with the influence of a config file and I will work again on this once I get an answer but I didn't want to wait for an unknown amount of time with the current version stuck in -proposed.

There's a PPA with this version (and I again forgot to append ~ppaX to the version for upload to the PPA) at https://launchpad.net/~adrien-n/+archive/ubuntu/attempting-to-break-everything/+packages (again, PPA name is a joke, but as we see with this MR, there's some justifiction to it).

To post a comment you must log in.
8b1b258... by Adrien Nader

Ignore system-wide gnutls configuration when running the testsuite.

Unmerged commits

8b1b258... by Adrien Nader

Ignore system-wide gnutls configuration when running the testsuite.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 7b4ab77..808c2bd 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,9 @@
6+gnutls28 (3.8.1-4ubuntu4) noble; urgency=medium
7+
8+ * Don't run the testsuite under the influence of a configuration file.
9+
10+ -- Adrien Nader <adrien.nader@canonical.com> Fri, 17 Nov 2023 11:08:39 +0100
11+
12 gnutls28 (3.8.1-4ubuntu3) noble; urgency=medium
13
14 * Forcefully disable TLS 1.0 and 1.1 through /etc/gnutls/config.
15diff --git a/debian/tests/run-upstream-testsuite b/debian/tests/run-upstream-testsuite
16index e061e36..bf88154 100755
17--- a/debian/tests/run-upstream-testsuite
18+++ b/debian/tests/run-upstream-testsuite
19@@ -51,7 +51,7 @@ for i in $(find ../../tests/ -type f -name '*.sh' | \
20 *)
21 d="";;
22 esac
23- if env srcdir=../../tests/$d sh $i ; then
24+ if env GNUTLS_SYSTEM_PRIORITY_FILE= srcdir=../../tests/$d sh $i ; then
25 echo SUCCESS [$count]$i
26 else
27 if [ $? = 77 ] ; then

Subscribers

People subscribed via source and target branches