Merge lp:~adriangoodyer/sudoku-app/test_about_tab into lp:sudoku-app

[adriangoodyer]

Completed test for the 'About' tab

Walkthrough:

- Switches to the 'About' tab
- Checks the tab is loaded
- Checks image loads correctly
- Checks all labels are present, with correct text
- Checks critical information is correct

[Dinko Osmankovic (dinko-metalac)]

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'sudoku-app.qml'
--- sudoku-app.qml	2013-07-15 09:22:56 +0000
+++ sudoku-app.qml	2013-07-16 16:59:38 +0000
@@ -689,6 +689,7 @@
                     anchors.horizontalCenter: parent.horizontalCenter;
                     y: units.gu(8);
                     Image {
+                        objectName: "aboutImage"
                         property real maxWidth: units.gu(100)
                         anchors.horizontalCenter: parent.horizontalCenter
                         width: Math.min(mainView.width, maxWidth)/1.75
@@ -702,28 +703,33 @@
                         //anchors.horizontalCenter: parent.horizontalCenter;
                         anchors.left: aboutColumn.left
                         Label {
+                            objectName: "authorLabel"
                             text: i18n.tr("Author(s): ")
 
                         }
                         Label {
+                            objectName: "authors"
+                            font.bold: true;
+                            text: "Dinko Osmankovic\nFr\u00e9d\u00e9ric Delgado\nGeorgi Karavasilev"
+                        }
+                    }
+                    Row {
+                        anchors.horizontalCenter: parent.horizontalCenter;
+                        Label {
+                            objectName: "contactLabel"
+                            text: i18n.tr("Contact: ")
+                        }
+                        Label {
+                            objectName: "contacts"
                             font.bold: true;
                             text: "Dinko Osmankovic\nFrédéric Delgado\nGeorgi Karavasilev"
                         }
                     }
                     Row {
-                        anchors.horizontalCenter: parent.horizontalCenter;
-                        Label {
-                            text: i18n.tr("Contact: ")
-                        }
-                        Label {
-                            font.bold: true;
-                            text: "[e-mail]\[e-mail]\[e-mail]"
-                        }
-                    }
-                    Row {
                         id: homepage;
                         anchors.horizontalCenter: parent.horizontalCenter;
                         Label {
+                            objectName: "urlLabel"
                             font.bold: true;
                             text: "<a href=\"https://launchpad.net/sudoku-app\">https://launchpad.net/sudoku-app</a>"
                             onLinkActivated: Qt.openUrlExternally(link)
@@ -735,9 +741,11 @@
                     anchors.top: aboutColumn.bottom;
                     anchors.topMargin: units.gu(5);
                     Label {
+                        objectName: "versionLabel"
                         text: i18n.tr("Version: ")
                     }
                     Label {
+                        objectName: "version"
                         font.bold: true;
                         text: "0.4"
                     }
@@ -747,6 +755,7 @@
                     anchors.top: aboutColumn.bottom;
                     anchors.topMargin: units.gu(8);
                     Label {
+                        objectName: "yearLabel"
                         font.bold: true;
                         text: "2013"
                     }

=== modified file 'tests/autopilot/sudoku_app/tests/test_sudoku.py'
--- tests/autopilot/sudoku_app/tests/test_sudoku.py	2013-07-12 10:12:39 +0000
+++ tests/autopilot/sudoku_app/tests/test_sudoku.py	2013-07-16 16:59:38 +0000
@@ -145,8 +145,44 @@
 		
 		number_of_hints = lambda: self.app.select_single(objectName="blockgrid").numberOfHints
 		self.assertThat(number_of_hints, Eventually(Equals(1)))
-		
-		
-
-		
+
+    def test_about_tab(self):
+        #Switch to the 'About' tab
+        self.ubuntusdk.switch_to_tab(3)
+
+        #Check for'About' tab selection
+        tabName = lambda: self.ubuntusdk.get_object("Tab", "aboutTab")
+        self.assertThat(tabName, Eventually(NotEquals(None)))
+
+        #Check image loads
+        aboutImage = lambda: self.ubuntusdk.get_object("QQuickImage", "aboutImage").progress
+        self.assertThat(aboutImage, Eventually(Equals(1.0)))
+
+        #Check the 'Author(s):' label is displayed
+        aboutLabel = lambda: self.ubuntusdk.get_object("Label", "authorLabel").text
+        self.assertThat(aboutLabel, Eventually(Equals("Author(s): ")))
+
+        #Check the 'Contact:' label is displayed
+        contactLabel = lambda: self.ubuntusdk.get_object("Label", "contactLabel").text
+        self.assertThat(contactLabel, Eventually(Equals("Contact: ")))
+
+        #Check correct Launchpad URL: is displayed
+        urlLabel = lambda: self.ubuntusdk.get_object("Label", "urlLabel").text
+        self.assertThat(urlLabel, Eventually(Equals(
+            "<a href=\"https://launchpad.net/sudoku-app\">https://launchpad.net/sudoku-app</a>")))
+
+        #Check the 'Version:' label is displayed
+        versionLabel = lambda: self.ubuntusdk.get_object("Label", "versionLabel").text
+        self.assertThat(versionLabel, Eventually(Equals("Version: ")))
+
+        #Check correct version is displayed
+        version = lambda: self.ubuntusdk.get_object("Label", "version").text
+        self.assertThat(version, Eventually(Equals("0.4")))
+
+        #Check correct year is displayed
+        yearLabel = lambda: self.ubuntusdk.get_object("Label", "yearLabel").text
+        self.assertThat(yearLabel, Eventually(Equals("2013")))
+        
+
+