Merge lp:~adrian-wilkins/bzr-xmloutput/dont-use-silent-ui.526740 into lp:bzr-xmloutput

Proposed by Adrian Wilkins
Status: Merged
Approved by: Guillermo Gonzalez
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~adrian-wilkins/bzr-xmloutput/dont-use-silent-ui.526740
Merge into: lp:bzr-xmloutput
Diff against target: 13 lines (+2/-1)
1 file modified
service.py (+2/-1)
To merge this branch: bzr merge lp:~adrian-wilkins/bzr-xmloutput/dont-use-silent-ui.526740
Reviewer Review Type Date Requested Status
Guillermo Gonzalez Approve
Review via email: mp+20021@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Adrian Wilkins (adrian-wilkins) wrote :

Fixes 2.1 release breaking most of the features of the XML-RPC server.

Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Looks good! thanks for fixing this so fast!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'service.py'
2--- service.py 2009-09-23 03:29:47 +0000
3+++ service.py 2010-02-23 23:46:13 +0000
4@@ -167,7 +167,8 @@
5 def custom_commands_main(argv):
6 """custom commands.main that handle errors using XMLError"""
7 import bzrlib.ui
8- bzrlib.ui.ui_factory = bzrlib.ui.SilentUIFactory()
9+ bzrlib.ui.ui_factory = bzrlib.ui.make_ui_for_terminal(
10+ sys.stdin, sys.stdout, sys.stderr)
11 try:
12 _argv = []
13 for a in argv[1:]:

Subscribers

People subscribed via source and target branches

to all changes: