Code review comment for lp:~adorsaz/homebank/adv-budget-with-categories

Hi Adrien,

I finally took time this morning to review this code, I still would like to add this to 5.3 as promise. For now I am still working on some refinement for many things in 5.3, and will release a 5.3 RC in a few days (I hope).

Anyway I would suggest some changes in your proposal before including it, no hurry for you, as I plan to release a final 5.3 on September, after a quite long RC period, due to the very deep changes I have made.

Here is a list:

bug2fix:
- the selection remains on a wrong line, sometimes
  to reproduce with example file
 under expense, click on income tax, goes to balance: OK the selection remains
 under expense, click on income tax, goes to income: total is selected (default) ?
 under expense, click on any category with no budget (Car/Fuel), goes to balance: KO, invoice is selected

changes2make:
- global: rename file/func name, menu title, dialog title to something like 'Budget (table view)'; ui_bud_tabview_xxx, because the axis of the dialog is only visual (semantic)
- dialog: disable edition (add/remove/merge) with HB_BUD_TABVIEW_EDIT_ENABLE, for now I prefer keep budget to input budget only, and category management separately, with pragmas you will be able to compile with that if you want
- dialog: top radio button should be Summary(or Synthesis)/Expense/Income, to follow semantic and other Hb dialog
- dialog: move the searchbar to topright

- list: remove the '(check forced display)' into the title + checkbox in profit of a single toggle button at bottom (I added a pin icon in the budget list fro 5.3, and will also for your list), this with lighten the display
- list: center title column
- list: add an empty column as last column, to avoid ugly right justify on last column
- list: total column should be displayed in 2nd position to ease reading
- list: display category with budget in bold to ease visual anchor
- list: display subcategories in italic

add2do:
- a way (button below the list to enable clear a budget line (similar to clear input in my budget dialog)

things2consider:
- list: add an 'Average' (by month) column just after/before total ?
- list: hide 0.00 when not usefull (to focus reading) ?