Merge lp:~adiroiban/pocket-lint/unicode-pyflakes into lp:pocket-lint

[Adi Roiban]

Here is the fix for encoding source before sending it to pyflakes.

Hope that travis-ci branch will land soon in master so that we can test on both python 3.3 and 2.7.

I have only tested on python 2.7

Thanks!

[Curtis Hovey (sinzui)]

Thank you.

review: Approve (code)

=== modified file 'pocketlint/formatcheck.py'
--- pocketlint/formatcheck.py	2013-11-06 15:21:20 +0000
+++ pocketlint/formatcheck.py	2014-02-05 18:44:51 +0000
@@ -633,7 +633,11 @@
         """Check compilation and syntax."""
         try:
             tree = compile(
-                self.text, self.file_path, "exec", _ast.PyCF_ONLY_AST)
+                self.text.encode(self.encoding),
+                self.file_path,
+                "exec",
+                _ast.PyCF_ONLY_AST,
+                )
         except (SyntaxError, IndentationError) as exc:
             line_no = exc.lineno or 0
             line = exc.text or ''

=== modified file 'pocketlint/tests/test_python.py'
--- pocketlint/tests/test_python.py	2013-02-16 18:03:51 +0000
+++ pocketlint/tests/test_python.py	2014-02-05 18:44:51 +0000
@@ -150,6 +150,21 @@
         self.assertEqual([], self.reporter.messages)
         self.assertEqual(0, self.reporter.call_count)
 
+    def test_pyflakes_unicode(self):
+        """
+        It handles Python non-ascii encoded files.
+        """
+        source = (
+            '# -*- coding: utf-8 -*-\n'
+            'variable = u"r\xe9sum\xe9"'
+            )
+        checker = PythonChecker('bogus', source, self.reporter)
+        # This should set the correct encoding.
+        checker.check_text()
+
+        checker.check_flakes()
+        self.assertEqual([], self.reporter.messages)
+
 
 class TestPEP8(CheckerTestCase):
     """Verify PEP8 integration."""