Code review comment for lp:~adiroiban/pocket-lint/travis-ci

Revision history for this message
Adi Roiban (adiroiban) wrote :

True... I see the warning... python packaging tools are a bit of a mess :(

How 'requires' is used in the context of distutils?

I have changed to install_requires since without that, pip install will not install the dependencies.

In the penultimate revision I added both version... with duplicate info but I don't like it :(

Is there a reason to keep using distutils and not setuptools, or at least not trying to use setuptools?

In the last revision I went for setuptools as primary tools and failing to disutils if setuptools are not found.

I find setuptools install command or pip install command much useful than distutils install commnand.

-----

While checking the sdist command, I see that it runs the tests, but will not prevent building the distribution if tests fails... maybe it needs something like this:

    def run(self):
        test_loader = unittest.defaultTestLoader
        suite = unittest.TestSuite()
        for test_module in test_loader.discover('pocketlint'):
            suite.addTest(test_module)
        result = unittest.TextTestRunner(verbosity=1).run(suite)
        if len(result.failures) or len(result.errors):
            raise AssertionError('Test have failed.')

Thanks!

« Back to merge proposal