Code review comment for lp:~adiroiban/pocket-lint/travis-ci

Revision history for this message
Adi Roiban (adiroiban) wrote :

I will use IS_PY3 ... sorry for that. I was not aware of this convention.

I have renamed requires to install_requires so that they will be installed by pip http://stackoverflow.com/questions/10335371/pip-does-not-install-dependency-declared-in-setup-requires-parameter

It looks like the PY3 check is required as this build fails : https://travis-ci.org/chevah/pocket-lint/builds/18262140

With the exception for py3 the test pass : https://travis-ci.org/chevah/pocket-lint/builds/18262337

The code works on Travis-CI https://travis-ci.org/chevah/pocket-lint

I have no idea why the MERGE markers are listed in this diff. I checked the branch and there are no markers: http://bazaar.launchpad.net/~adiroiban/pocket-lint/travis-ci/view/head:/setup.py

Please review latest changes. Thanks!

« Back to merge proposal