Code review comment for lp:~adiroiban/pocket-lint/pocket-lint-764627

Revision history for this message
Curtis Hovey (sinzui) wrote :

Firstly, good_python is intended to be good code that does not cause any errors. Hacking it to not do that implies it is not good python. The good_python should not be used to test a rare case.

I expect to see a new test that only exercises the lines of code that changed. I think you want to create a separate example to test called bad_windowserrror_python and add a new test to TestPyflakes that verifies everything is okay.

review: Needs Fixing (code)

« Back to merge proposal