Code review comment for lp:~adiroiban/pocket-lint/pocket-lint-764627

The updated 'good_python' text is raising the WindowsError in the default pyflakes.

If run the tests on Linux using the updated test with the current formatchecker.py code you will see that the tests are failing.

Do you want me to test that WindowsError is raised when using the default pyflakes checker and the it is ignored when using the modified pyflackes checker?

There was an error in the initial code this is why PocketLintPyFlakesChecker was also added to the pep8 check.
If you look at the check_pep8 you will see that pep8.Checker.report_error is monkey patched, but then pyflakes Checker.report_error is restored.

I have updated the code to reflect this error.

I have imported the pyflackes Checker as PyFlakesChecker since using the generic Checker name can be confusing and it could lead to errors like the one discovered now.

I am not sure what I understood your request.

We can also talk via FreeNode IRC . my nickname is adiroiban

Cheers,