Code review comment for lp:~adiroiban/pocket-lint/pocket-lint-764627

Revision history for this message
Curtis Hovey (sinzui) wrote :

I was initial -1 on handling this issue in pocket-lint, but I see your implementation provides a lot of opportunities for future development. Your PocketLintPyFlakesChecker subclass could accept a Reporter instance either in __init__ or check to remove the integration hack that is visible in the diff. I am not +1 about this change.

I want to merge your branch, but before I do, can you help me understand the test change? I expect to see an explicit test that will raise WindowsError or cause it to be raised. The change I see looks like it it updating an existing test, but it is not clear which test is checking for this. I also do not understand how the added try/except tests that the subclass suppresses the error

review: Needs Information (code)

« Back to merge proposal