Merge lp:~adiroiban/pocket-lint/pep-in-memory into lp:pocket-lint
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~adiroiban/pocket-lint/pep-in-memory | ||||
Merge into: | lp:pocket-lint | ||||
Diff against target: |
235 lines (+39/-43) 3 files modified
pocketlint/formatcheck.py (+16/-3) pocketlint/tests/test_python.py (+19/-37) pocketlint/tests/test_text.py (+4/-3) |
||||
To merge this branch: | bzr merge lp:~adiroiban/pocket-lint/pep-in-memory | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey | Pending | ||
Review via email:
|
Description of the change
Description
----------
To allow in memory check of pep8 code , pocket-lint should pass already parsed lines to pep8 instead of only passing the filepath so that a file is only read once.
Changes
-------
I have updated check_pep8
I have updated tests to use the new PocketLintOptions object and stop using the mocked Bunch object.
I have updated the max_line_lenght update in PocketLintOption to keep in sync the pep8 option.
I have updated style so that pocket-lint code will pass pocket-lint checks.
Maybe we should update test.py to also run pocket-lint on the pocket-lint source code? What do you think? I can do that in separate branch. This can also be usefull for travis-ci integration.
Please let me know what do you think.
Unmerged revisions
- 453. By Adi Roiban <email address hidden>
-
Initial code to fix pep8 in memory check.