Merge lp:~adiroiban/pocket-lint/911051 into lp:pocket-lint

Proposed by Adi Roiban
Status: Merged
Approved by: Curtis Hovey
Approved revision: 406
Merged at revision: 407
Proposed branch: lp:~adiroiban/pocket-lint/911051
Merge into: lp:pocket-lint
Diff against target: 13 lines (+3/-0)
1 file modified
pocketlint/formatcheck.py (+3/-0)
To merge this branch: bzr merge lp:~adiroiban/pocket-lint/911051
Reviewer Review Type Date Requested Status
Curtis Hovey code Approve
Review via email: mp+87399@code.launchpad.net

Description of the change

This is a simple fix that stops pocketlint for searching for JS interpretors on non posix systems.

Please let me know if this requires a test or you want this bug to be fixed in another way.

Cheers,
Adi

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

This looks good to land. I will merge it now.

I intend to do a pocket-lint release this week.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'pocketlint/formatcheck.py'
2--- pocketlint/formatcheck.py 2011-12-20 10:29:38 +0000
3+++ pocketlint/formatcheck.py 2012-01-03 18:48:33 +0000
4@@ -48,6 +48,9 @@
5
6 def find_exec(names):
7 """Return the name of a GI enabled JS interpreter."""
8+ if os.name != 'posix':
9+ return None
10+
11 for name in names:
12 js = subprocess.Popen(
13 ['which', name], stdout=subprocess.PIPE, stderr=subprocess.PIPE)

Subscribers

People subscribed via source and target branches

to all changes: