Code review comment for lp:~adiroiban/pocket-lint/1168854-google-closure

changes for 40-41 should be reverted... It is my error. I have not run the test.

This code is not correct as it was just a prototype. My local version is a mess but will push a new version.

Some errors will be duplicated (ex long lines)... I plan to white list by default.

I like closure_lint since it is pure python and on Windows it works out of the box.
JSLint/JSHint is nice, but it requires a JS interpreter... and I don't know if right now pocket-lint can use JSLint out of the box.

For now I use both JSHint and closure linter without any conflict...but I guess that users will choose between one js checker and will not use both.

Beside full python support, I like closure linter since it does a some more strict checks on styleguide to make sure that the code look like being written by a single person.

For example closure linter will make a different this code

"""
var test = function(){
}
"""

and this one

"""
var test = function() {
}
"""

While JSHint has noting to comment.

closure linter also complai about missing space between operators so will complain for code like """var a=b;""" as it wants """var a = b;"""

-----

The purporse of this initial review is to see if you want google closure linter. If you want to have support for closure linter, I will come back with a new branch with tests.

Now, I/we can also think of a plugin system for pocketlint so that I (others) can implement 3rd party checkers.

Cheers,