Code review comment for lp:~adiroiban/pocket-lint/1168854-google-closure

Revision history for this message
Curtis Hovey (sinzui) wrote :

The tests could have a guard at the top. I think some css tests do this...and I see your function does this. The test can do the same.

I am concerned about the change on lines 40-41. I added this to test under python3. Did the tests pass under py2 and py3 after this change?

What does closure_linter provide that jslint does not? Am I going to see duplicate warnings and errors? Do jsline and closure_lint disagree about style, making it impossible to write without warngings? I think this provides jsdoc checking too. http://anton.averin.pro/2012/08/17/js_quality_tools_jshint_jslint_gjslinter/ implies there could be disagreement, and that it is not going to catch the errors that jslint does.

review: Needs Information (code)

« Back to merge proposal