Merge lp:~adiroiban/launchpad/bug-487137 into lp:launchpad

[Adi Roiban]

Allow Rosetta Experts to administer custom language codes.

= Bug 487137 =

Now that we have the custom language codes UI (bug 271747), we should allow Translations experts to create and remove custom language codes.

This was always planned, but didn't fit in the original branch.

== Proposed fix ==

Use launchpad.TranslationsAdmin for checking admin permissions for custom language codes.
Allow Launchpad Admin and Rosetta Admin launchpad.TranslationsAdmin rights on ICustomLanguageCode and IHasCustomLanguageCodes.

== Pre-implementation notes ==

None yet.

== Implementation details ==

Nothing special.

I don't know what is the best method for testing permission, since all permission checking tests should be done using a Launchpad admins and a Rosetta expert.

'make lint' sometimes gives me > bzr: ERROR: unknown command "pipes"

== Tests ==

lp-test custom-language-codes

== Demo and Q/A ==

Login as Rosetta Administrator.
Go to a product or sourcepackage page:

https://translations.launchpad.dev/evolution
https://translations.launchpad.dev/ubuntu/+source/evolution

You should see a link for defining custom language codes.
Click on the link.
Add a language code.
Click on the new language code.
Remove the language code.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/security.py
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/browser/customlanguagecode.py
  lib/lp/translations/stories/standalone/custom-language-codes.txt
  lib/lp/translations/templates/customlanguagecode-index.pt
  lib/lp/translations/templates/customlanguagecodes-index.pt
  lib/lp/translations/templates/product-portlet-translatables.pt
  lib/lp/translations/templates/sourcepackage-translations.pt

[Michael Nelson (michael.nelson)]

Hi Adi!

Thanks for yet another branch. The test is failing for me locally, and I've a few typo fixes below. Once they're fixed up, r=me.

Thanks!

On Thu, Apr 22, 2010 at 5:19 AM, Adi Roiban <email address hidden> wrote:
> Adi Roiban has proposed merging lp:~adiroiban/launchpad/bug-487137 into lp:launchpad/devel.
...
>
> == Tests ==<email address hidden>
>
> lp-test custom-language-codes

Running the test results in a failure:
http://pastebin.ubuntu.com/420372/

>
> == Demo and Q/A ==
>
> Login as Rosetta Administrator.
> Go to a product or sourcepackage page:
>
> https://translations.launchpad.dev/evolution
> https://translations.launchpad.dev/ubuntu/+source/evolution
>
> You should see a link for defining custom language codes.
> Click on the link.
> Add a language code.
> Click on the new language code.
> Remove the language code.

Great. Strangely, reverting your security.py change and logging in as <email address hidden> still allows me to create language codes, just not delete them.

I see it's not really part of this branch, but when removing a language there is no text (other than the main heading, breadcrumbs and the remove or cancel options). It looks a bit strange, and any text would just be repeating what the main heading already says, but adding the label to the form might look less strange... see what you think (as it's not part of this branch, I'll leave it up to you).

> === modified file 'lib/canonical/launchpad/security.py'
> --- lib/canonical/launchpad/security.py 2010-04-18 22:31:40 +0000
> +++ lib/canonical/launchpad/security.py 2010-04-22 03:19:15 +0000
> @@ -112,6 +112,8 @@
> from lp.blueprints.interfaces.sprintspecification import (
> ISprintSpecification)
> from lp.registry.interfaces.teammembership import ITeamMembership
> +from lp.translations.interfaces.customlanguagecode import (
> + ICustomLanguageCode, IHasCustomLanguageCodes)
> from lp.translations.interfaces.translationgroup import (
> ITranslationGroup, ITranslationGroupSet)
> from lp.translations.interfaces.translationimportqueue import (
> @@ -1652,6 +1654,28 @@
> usedfor = ILanguage
>
>
> +class AdminCustomLanguageCodes(OnlyRosettaExpertsAndAdmins):
> + """Controls administration of custom language codes.
> +
> + Rosetta expters and Launchpad administrators can admister custom language

s/expters/experts
s/admister/administer

> + codes.
> + """
> +
> + permission = 'launchpad.TranslationsAdmin'
> + usedfor = IHasCustomLanguageCodes
> +
> +
> +class AdminCustomLanguageCode(OnlyRosettaExpertsAndAdmins):
> + """Controls administration for a custom language code.
> +
> + Rosetta expters and Launchpad administrators can admister a custom

as above.

> + language code.
> + """
> +
> + permission = 'launchpad.TranslationsAdmin'
> + usedfor = ICustomLanguageCode
> +
> +
> class AccessBranch(AuthorizationBase):
> """Controls visibility of branches.
>
>

> === modified file 'lib/lp/translations/stories/standalone/custom-language-codes.txt'
> --- lib/lp/translations/stories/standalone/custom-language-codes.txt 2010-03-11 20:54:36 +0000
> +++ lib/lp/translations/stories/standalone/custom-language-codes.txt 2010-04-22 03:19:15 +0000
....

review: Approve (code)

[Adi Roiban (adiroiban)]

> Hi Adi!
>
> Thanks for yet another branch. The test is failing for me locally, and I've a
> few typo fixes below. Once they're fixed up, r=me.

Thanks for taking the time and review this branch!
Please see my inline comments.

[snip]

> > lp-test custom-language-codes
>
> Running the test results in a failure:
> http://pastebin.ubuntu.com/420372/

Test fixed.
It was my fault for changing the test and not running it again.

> > == Demo and Q/A ==
> >
> > Login as Rosetta Administrator.
> > Go to a product or sourcepackage page:
> >
> > https://translations.launchpad.dev/evolution
> > https://translations.launchpad.dev/ubuntu/+source/evolution
> >
> > You should see a link for defining custom language codes.
> > Click on the link.
> > Add a language code.
> > Click on the new language code.
> > Remove the language code.
>
> Great. Strangely, reverting your security.py change and logging in as
> <email address hidden> still allows me to create language codes, just not delete them.

Yes. It should work for IProduct since Rosetta Experts have already translations admin right on IProduct which implements IHasCustomLangaugeCode. They don't have this right on ISourcePackage which also implement IHasCustomLangaugeCode.

> I see it's not really part of this branch, but when removing a language there
> is no text (other than the main heading, breadcrumbs and the remove or cancel
> options). It looks a bit strange, and any text would just be repeating what
> the main heading already says, but adding the label to the form might look
> less strange... see what you think (as it's not part of this branch, I'll
> leave it up to you).

I have added the text:
You are going to remove the custom language code "LC".

> > === modified file 'lib/canonical/launchpad/security.py'
> > --- lib/canonical/launchpad/security.py 2010-04-18 22:31:40 +0000
> > +++ lib/canonical/launchpad/security.py 2010-04-22 03:19:15 +0000
> > @@ -112,6 +112,8 @@
> > from lp.blueprints.interfaces.sprintspecification import (
> > ISprintSpecification)
> > from lp.registry.interfaces.teammembership import ITeamMembership
> > +from lp.translations.interfaces.customlanguagecode import (
> > + ICustomLanguageCode, IHasCustomLanguageCodes)
> > from lp.translations.interfaces.translationgroup import (
> > ITranslationGroup, ITranslationGroupSet)
> > from lp.translations.interfaces.translationimportqueue import (
> > @@ -1652,6 +1654,28 @@
> > usedfor = ILanguage
> >
> >
> > +class AdminCustomLanguageCodes(OnlyRosettaExpertsAndAdmins):
> > + """Controls administration of custom language codes.
> > +
> > + Rosetta expters and Launchpad administrators can admister custom
> language
>
> s/expters/experts
> s/admister/administer

Fixed.

> > + codes.
> > + """
> > +
> > + permission = 'launchpad.TranslationsAdmin'
> > + usedfor = IHasCustomLanguageCodes
> > +
> > +
> > +class AdminCustomLanguageCode(OnlyRosettaExpertsAndAdmins):
> > + """Controls administration for a custom language code.
> > +
> > + Rosetta expters and Launchpad administrators can admister a custom
>
> as above.

Fixed.
[snip]
> > -An administrator sees the link to the custom language codes on a
> ...

[Michael Nelson (michael.nelson)]

Great, thanks for those changes Adi.

Just ping me and I'll send this off to land if you're happy with it.

[Данило Шеган (danilo)]

Henning has picked up this branch and massaged it for landing. Thanks Adi for the work on it so far :)

=== modified file 'lib/canonical/launchpad/security.py'
--- lib/canonical/launchpad/security.py	2010-04-20 08:01:41 +0000
+++ lib/canonical/launchpad/security.py	2010-04-22 16:33:28 +0000
@@ -112,6 +112,8 @@
 from lp.blueprints.interfaces.sprintspecification import (
     ISprintSpecification)
 from lp.registry.interfaces.teammembership import ITeamMembership
+from lp.translations.interfaces.customlanguagecode import (
+    ICustomLanguageCode, IHasCustomLanguageCodes)
 from lp.translations.interfaces.translationgroup import (
     ITranslationGroup, ITranslationGroupSet)
 from lp.translations.interfaces.translationimportqueue import (
@@ -1652,6 +1654,28 @@
     usedfor = ILanguage
 
 
+class AdminCustomLanguageCodes(OnlyRosettaExpertsAndAdmins):
+    """Controls administration of custom language codes.
+
+    Rosetta experts and Launchpad administrators can administer custom
+    language codes.
+    """
+
+    permission = 'launchpad.TranslationsAdmin'
+    usedfor = IHasCustomLanguageCodes
+
+
+class AdminCustomLanguageCode(OnlyRosettaExpertsAndAdmins):
+    """Controls administration for a custom language code.
+
+    Rosetta experts and Launchpad administrators can administer a custom
+    language code.
+    """
+
+    permission = 'launchpad.TranslationsAdmin'
+    usedfor = ICustomLanguageCode
+
+
 class AccessBranch(AuthorizationBase):
     """Controls visibility of branches.
 

=== modified file 'lib/lp/translations/browser/configure.zcml'
--- lib/lp/translations/browser/configure.zcml	2010-04-19 08:11:52 +0000
+++ lib/lp/translations/browser/configure.zcml	2010-04-22 16:33:28 +0000
@@ -1001,9 +1001,9 @@
     <browser:page
         name="+remove"
         for="lp.translations.interfaces.customlanguagecode.ICustomLanguageCode"
-        permission="launchpad.Admin"
+        permission="launchpad.TranslationsAdmin"
         class="lp.translations.browser.customlanguagecode.CustomLanguageCodeRemoveView"
-        template="../../app/templates/generic-edit.pt"
+        template="../templates/customlanguagecode-remove.pt"
         layer="canonical.launchpad.layers.TranslationsLayer"/>
 
 <!-- IHasCustomLanguageCodes -->
@@ -1021,7 +1021,7 @@
         layer="canonical.launchpad.layers.TranslationsLayer"
         class="lp.translations.browser.customlanguagecode.CustomLanguageCodeAddView"
         template="../templates/customlanguagecode-add.pt"
-        permission="launchpad.Admin"/>
+        permission="launchpad.TranslationsAdmin"/>
 
     </facet>
 </configure>

=== modified file 'lib/lp/translations/browser/customlanguagecode.py'
--- lib/lp/translations/browser/customlanguagecode.py	2009-11-13 16:18:54 +0000
+++ lib/lp/translations/browser/customlanguagecode.py	2010-04-22 16:33:28 +0000
@@ -11,7 +11,7 @@
     'CustomLanguageCodeView',
     'HasCustomLanguageCodesNavigation',
     'HasCustomLanguageCodesTraversalMixin',
-	]
+    ]
 
 
 import re

=== modified file 'lib/lp/translations/stories/standalone/custom-language-codes.txt'
--- lib/lp/translations/stories/standalone/custom-language-codes.txt	2010-03-11 20:54:36 +0000
+++ lib/lp/translations/stories/standalone/custom-language-codes.txt	2010-04-22 16:33:28 +0000
@@ -11,7 +11,6 @@
 Custom language codes are attached to either a product or a source
 package.
 
-    >>> import re
     >>> from zope.component import getUtility
     >>> from zope.security.proxy import removeSecurityProxy
     >>> from canonical.launchpad.interfaces.launchpad import (
@@ -35,9 +34,10 @@
     >>> logout()
 
     >>> owner_browser = setupBrowser("Basic [e-mail]:test")
+    >>> rosetta_admin_browser = setupRosettaExpertBrowser()
 
-An administrator sees the link to the custom language codes on a
-project's main translations page.
+A Launchpad administrator or Rosetta expert sees the link to the custom
+language codes on a project's main translations page.
 
     >>> admin_browser.open(product_page)
     >>> tag = find_custom_language_codes_link(admin_browser)
@@ -46,10 +46,17 @@
     define custom language codes
     for this project.
 
+    >>> rosetta_admin_browser.open(product_page)
+    >>> tag = find_custom_language_codes_link(rosetta_admin_browser)
+    >>> print extract_text(tag.renderContents())
+    If necessary, you may
+    define custom language codes
+    for this project.
+
 The link goes to the custom language codes management page.
 
-    >>> admin_browser.getLink("define custom language codes").click()
-    >>> custom_language_codes_page = admin_browser.url
+    >>> rosetta_admin_browser.getLink("define custom language codes").click()
+    >>> custom_language_codes_page = rosetta_admin_browser.url
 
 Non-admins, even the project's owner, don't see this link.  We do not
 advertise this feature, since the proper solution is generally to use
@@ -61,26 +68,26 @@
 
 Initially the page shows no custom language codes for the project.
 
-    >>> tag = find_tag_by_id(admin_browser.contents, 'empty')
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'empty')
     >>> print extract_text(tag.renderContents())
     No custom language codes have been defined.
 
 The admin can add a custom language code.
 
-    >>> admin_browser.getLink("Add a custom language code").click()
-    >>> add_page = admin_browser.url
+    >>> rosetta_admin_browser.getLink("Add a custom language code").click()
+    >>> add_page = rosetta_admin_browser.url
 
-    >>> admin_browser.getControl("Language code:").value = 'no'
-    >>> admin_browser.getControl("Language:").value = ['nn']
-    >>> admin_browser.getControl("Add").click()
+    >>> rosetta_admin_browser.getControl("Language code:").value = 'no'
+    >>> rosetta_admin_browser.getControl("Language:").value = ['nn']
+    >>> rosetta_admin_browser.getControl("Add").click()
 
 This leads back to the custom language codes overview, where the new
 code is now shown.
 
-    >>> admin_browser.url == custom_language_codes_page
+    >>> rosetta_admin_browser.url == custom_language_codes_page
     True
 
-    >>> tag = find_tag_by_id(admin_browser.contents, 'nonempty')
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'nonempty')
     >>> print extract_text(tag.renderContents())
     Foo uses the following custom language codes:
     Code...     ...maps to language
@@ -89,8 +96,8 @@
 There is an overview page for the custom code, though there's not much
 to see there.
 
-    >>> admin_browser.getLink("no").click()
-    >>> main = find_main_content(admin_browser.contents)
+    >>> rosetta_admin_browser.getLink("no").click()
+    >>> main = find_main_content(rosetta_admin_browser.contents)
     >>> print extract_text(main.renderContents())
     Foo Translations Custom language code ...no...
     For Foo, uploads with the language code
@@ -102,26 +109,27 @@
 
 The overview page leads back to the custom language codes overview.
 
-    >>> code_page = admin_browser.url
-    >>> admin_browser.getLink("custom language codes overview").click()
-    >>> admin_browser.url == custom_language_codes_page
+    >>> code_page = rosetta_admin_browser.url
+    >>> rosetta_admin_browser.getLink(
+    ...     "custom language codes overview").click()
+    >>> rosetta_admin_browser.url == custom_language_codes_page
     True
 
-    >>> admin_browser.open(code_page)
+    >>> rosetta_admin_browser.open(code_page)
 
 There is also a link for removing codes.  The admin follows the link and
 removes the "no" custom language code.
 
-    >>> admin_browser.getLink("remove custom language code").click()
-    >>> remove_page = admin_browser.url
-    >>> admin_browser.getControl("Remove").click()
+    >>> rosetta_admin_browser.getLink("remove custom language code").click()
+    >>> remove_page = rosetta_admin_browser.url
+    >>> rosetta_admin_browser.getControl("Remove").click()
 
 This leads back to the overview page.
 
-    >>> admin_browser.url == custom_language_codes_page
+    >>> rosetta_admin_browser.url == custom_language_codes_page
     True
 
-    >>> tag = find_tag_by_id(admin_browser.contents, 'empty')
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'empty')
     >>> print extract_text(tag.renderContents())
     No custom language codes have been defined.
 
@@ -155,10 +163,10 @@
 And naturally, if an admin creates a custom language code again, a
 non-admin can't remove it.
 
-    >>> admin_browser.open(add_page)
-    >>> admin_browser.getControl("Language code:").value = 'no'
-    >>> admin_browser.getControl("Language:").value = ['nn']
-    >>> admin_browser.getControl("Add").click()
+    >>> rosetta_admin_browser.open(add_page)
+    >>> rosetta_admin_browser.getControl("Language code:").value = 'no'
+    >>> rosetta_admin_browser.getControl("Language:").value = ['nn']
+    >>> rosetta_admin_browser.getControl("Add").click()
 
     >>> owner_browser.open(custom_language_codes_page)
     >>> tag = find_tag_by_id(owner_browser.contents, 'nonempty')
@@ -210,36 +218,36 @@
     ...     rootsite="translations")
     >>> logout()
 
-    >>> admin_browser.open(package_page)
+    >>> rosetta_admin_browser.open(package_page)
 
 Of course in this case, the notice about there being no custom language
 codes talks about a package, not a project.
 
-    >>> tag = find_custom_language_codes_link(admin_browser)
+    >>> tag = find_custom_language_codes_link(rosetta_admin_browser)
     >>> print extract_text(tag.renderContents())
     If necessary, you may
     define custom language codes
     for this package.
 
-    >>> admin_browser.getLink("define custom language codes").click()
-    >>> custom_language_codes_page = admin_browser.url
+    >>> rosetta_admin_browser.getLink("define custom language codes").click()
+    >>> custom_language_codes_page = rosetta_admin_browser.url
 
-    >>> tag = find_tag_by_id(admin_browser.contents, 'empty')
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'empty')
     >>> print extract_text(tag.renderContents())
     No custom language codes have been defined.
 
 Again, an admin can add a language code.
 
-    >>> admin_browser.getLink("Add a custom language code").click()
-    >>> add_page = admin_browser.url
+    >>> rosetta_admin_browser.getLink("Add a custom language code").click()
+    >>> add_page = rosetta_admin_browser.url
 
-    >>> admin_browser.getControl("Language code:").value = 'pt-br'
-    >>> admin_browser.getControl("Language:").value = ['pt_BR']
-    >>> admin_browser.getControl("Add").click()
+    >>> rosetta_admin_browser.getControl("Language code:").value = 'pt-br'
+    >>> rosetta_admin_browser.getControl("Language:").value = ['pt_BR']
+    >>> rosetta_admin_browser.getControl("Add").click()
 
 The language code is displayed.
 
-    >>> tag = find_tag_by_id(admin_browser.contents, 'nonempty')
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'nonempty')
     >>> print extract_text(tag.renderContents())
     bar in distro uses the following custom language codes:
     Code...     ...maps to language
@@ -248,15 +256,15 @@
 It's also displayed identically on the same package but in another
 release series of the same distribution.
 
-    >>> admin_browser.open(page_in_other_series)
-    >>> tag = find_custom_language_codes_link(admin_browser)
+    >>> rosetta_admin_browser.open(page_in_other_series)
+    >>> tag = find_custom_language_codes_link(rosetta_admin_browser)
     >>> print extract_text(tag.renderContents())
     If necessary, you may
     define custom language codes
     for this package.
 
-    >>> admin_browser.getLink("define custom language codes").click()
-    >>> tag = find_tag_by_id(admin_browser.contents, 'nonempty')
+    >>> rosetta_admin_browser.getLink("define custom language codes").click()
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'nonempty')
     >>> print extract_text(tag.renderContents())
     bar in distro uses the following custom language codes:
     Code...     ...maps to language
@@ -265,13 +273,13 @@
 
 The new code has a link there...
 
-    >>> admin_browser.getLink("pt-br").click()
+    >>> rosetta_admin_browser.getLink("pt-br").click()
 
 ...and can be deleted.
 
-    >>> admin_browser.getLink("remove custom language code").click()
-    >>> admin_browser.getControl("Remove").click()
+    >>> rosetta_admin_browser.getLink("remove custom language code").click()
+    >>> rosetta_admin_browser.getControl("Remove").click()
 
-    >>> tag = find_tag_by_id(admin_browser.contents, 'empty')
+    >>> tag = find_tag_by_id(rosetta_admin_browser.contents, 'empty')
     >>> print extract_text(tag.renderContents())
     No custom language codes have been defined.

=== modified file 'lib/lp/translations/templates/customlanguagecode-index.pt'
--- lib/lp/translations/templates/customlanguagecode-index.pt	2009-11-05 14:45:13 +0000
+++ lib/lp/translations/templates/customlanguagecode-index.pt	2010-04-22 16:33:28 +0000
@@ -26,7 +26,7 @@
 
     <div class="portlet">
       <ul class="horizontal">
-        <li tal:condition="context/required:launchpad.Admin">
+        <li tal:condition="context/required:launchpad.TranslationsAdmin">
           <a class="remove sprite"
              tal:attributes="href context/fmt:url/+remove">
             remove custom language code

=== added file 'lib/lp/translations/templates/customlanguagecode-remove.pt'
--- lib/lp/translations/templates/customlanguagecode-remove.pt	1970-01-01 00:00:00 +0000
+++ lib/lp/translations/templates/customlanguagecode-remove.pt	2010-04-22 16:33:28 +0000
@@ -0,0 +1,18 @@
+<html
+  xmlns="http://www.w3.org/1999/xhtml"
+  xmlns:tal="http://xml.zope.org/namespaces/tal"
+  xmlns:metal="http://xml.zope.org/namespaces/metal"
+  xmlns:i18n="http://xml.zope.org/namespaces/i18n"
+  metal:use-macro="view/macro:page/main_only"
+  i18n:domain="launchpad">
+  <body>
+    <div metal:fill-slot="main">
+      <div metal:use-macro="context/@@launchpad_form/form">
+        <div metal:fill-slot="extra_info" class="documentDescription">
+          You are going to remove the custom language code
+          '<tal:language-code replace="view/code" />'.
+        </div>
+      </div>
+    </div>
+  </body>
+</html>

=== modified file 'lib/lp/translations/templates/customlanguagecodes-index.pt'
--- lib/lp/translations/templates/customlanguagecodes-index.pt	2009-11-05 14:45:13 +0000
+++ lib/lp/translations/templates/customlanguagecodes-index.pt	2010-04-22 16:33:28 +0000
@@ -33,7 +33,8 @@
           <tr>
             <th>Code...</th>
             <th>...maps to language</th>
-            <th tal:condition="context/required:launchpad.Admin"></th>
+            <th tal:condition="context/required:launchpad.TranslationsAdmin">
+            </th>
           </tr>
         </thead>
         <tbody>
@@ -51,7 +52,7 @@
                 &mdash;
               </tal:nolanguage>
             </td>
-            <td tal:condition="context/required:launchpad.Admin">
+            <td tal:condition="context/required:launchpad.TranslationsAdmin">
               <a tal:attributes="href entry/fmt:url/+remove"
                  alt="Remove"
                  title="Remove"
@@ -70,7 +71,7 @@
 
     <div>
       <a tal:attributes="href context/fmt:url/+add-custom-language-code"
-         tal:condition="context/required:launchpad.Admin"
+         tal:condition="context/required:launchpad.TranslationsAdmin"
          class="add sprite">
         Add a custom language code
       </a>

=== modified file 'lib/lp/translations/templates/product-portlet-translatables.pt'
--- lib/lp/translations/templates/product-portlet-translatables.pt	2009-11-17 10:17:34 +0000
+++ lib/lp/translations/templates/product-portlet-translatables.pt	2010-04-22 16:33:28 +0000
@@ -65,7 +65,7 @@
 </div>
 
 <div class="portlet"
-     tal:condition="context/required:launchpad.Admin"
+     tal:condition="context/required:launchpad.TranslationsAdmin"
      id="custom-language-codes">
   If necessary, you may
   <a tal:attributes="href context/fmt:url/+custom-language-codes"

=== modified file 'lib/lp/translations/templates/sourcepackage-translations.pt'
--- lib/lp/translations/templates/sourcepackage-translations.pt	2009-11-17 10:17:34 +0000
+++ lib/lp/translations/templates/sourcepackage-translations.pt	2010-04-22 16:33:28 +0000
@@ -39,7 +39,7 @@
               <a tal:attributes="href context/menu:navigation/download/url">
                 download a full tarball</a> with translations.
             </p>
-            <p tal:condition="context/required:launchpad.Admin"
+            <p tal:condition="context/distribution_sourcepackage/required:launchpad.TranslationsAdmin"
                id="custom-language-codes">
               If necessary, you may
               <a tal:attributes="href context/distribution_sourcepackage/fmt:url/+custom-language-codes"