Merge lp:~adiroiban/launchpad/bug-340662 into lp:launchpad
Proposed by
Adi Roiban
Status: | Merged |
---|---|
Merged at revision: | not available |
Proposed branch: | lp:~adiroiban/launchpad/bug-340662 |
Merge into: | lp:launchpad |
Diff against target: |
222 lines (+63/-24) 6 files modified
lib/canonical/launchpad/security.py (+26/-1) lib/lp/translations/browser/potemplate.py (+3/-2) lib/lp/translations/configure.zcml (+8/-2) lib/lp/translations/stories/productseries/xx-productseries-templates.txt (+21/-8) lib/lp/translations/stories/standalone/xx-potemplate-edit.txt (+4/-10) lib/lp/translations/templates/object-templates.pt (+1/-1) |
To merge this branch: | bzr merge lp:~adiroiban/launchpad/bug-340662 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Disapprove | ||
Eleanor Berger (community) | Approve | ||
Review via email: mp+16629@code.launchpad.net |
To post a comment you must log in.
= Bug 340662=
At the moment, "change details" link on POTemplates has very limited options.
We should move at least translation domain, path and "accept translations" from "Admin" to "Change details" form.
== Proposed fix ==
Add template name, translation domain, path and iscurrent (accept translations) to the +edit page for potemplate and potemplates subset.
== Pre-implementation notes ==
There are no pre-implementation notes.
== Implementation details ==
launchpad.Edit for POTemplate and POTemplateSubset is a subset of launchpad. TranslationsAdm in To allow access to disabled templates for product owner or translations admins the URL traversal permission check was changed to launchpad.Edit.
Other users have no access to disabled templates
== Tests == templates
lp-test -t productseries-
== Demo and Q/A == /translations. launchpad. dev/evolution/ trunk/+ pots/evolution- 2.2/
As a product owner (ex. <email address hidden>) for a project (ex. evolution) go to a template page for that project
https:/
You should see the „Change details” that links to the +edit page
From this page you should be able to change template name, domain name, path, details, priority, owner and „accept translation”.
Change some values and then save them.
From the series +template page you will see „Edit” links for each template, including disabled templates: /translations. launchpad. dev/evolution/ trunk/+ templates
https:/
Disabling a template it should still be in the list (with a red background) and you can still edit it.
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: /launchpad/ security. py translations/ configure. zcml translations/ browser/ potemplate. py translations/ stories/ productseries/ xx-productserie s-templates. txt translations/ stories/ standalone/ xx-potemplate- edit.txt translations/ templates/ object- templates. pt
lib/canonical
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/