Merge lp:~adiroiban/launchpad/bug-193750 into lp:launchpad
Proposed by
Adi Roiban
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Henning Eggers | ||||
Approved revision: | not available | ||||
Merge reported by: | Adi Roiban | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~adiroiban/launchpad/bug-193750 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
194 lines (+85/-11) 3 files modified
lib/lp/translations/browser/language.py (+8/-0) lib/lp/translations/stories/standalone/xx-language.txt (+68/-7) lib/lp/translations/templates/language-index.pt (+9/-4) |
||||
To merge this branch: | bzr merge lp:~adiroiban/launchpad/bug-193750 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Abel Deuring (community) | code | Approve | |
Review via email: mp+15292@code.launchpad.net |
Commit message
Update the links for adding a question for Rosetta from addticket to addquestion. Make them use the answers.lp.net domain name.
To post a comment you must log in.
= Bug 193750 =
== Proposed fix ==
The fix should replace "ticket" to "question" and update the required answer links for addticket to addquestions.
Also instead on translations. lp.dev/ rosetta/ addticket the url was replaces to answers. lp.dev/ rosetta/ addquestion to have a clean namespace
== Implementation details ==
There were no test for checking the cases when those links should appear so I have added the required pagetests.
The translate.txt pagetest was also structured... but a bit.
== Tests ==
./bin/test -ct language
== Demo and Q/A ==
Abkhazian is a language that has no information about plural forms and is not registered as being spoken in any country.
We will see a note about missing plural forms and a link to Rosetta
add question page for informing Rosetta admin about the right plural form.
>>> browser.open('http:// translations. launchpad. dev/+languages/ ab') text(find_ portlet( browser. contents, 'Plural forms'
>>> print extract_
... ).renderContents())
Plural forms
Unfortunately, Launchpad doesn't know the plural
form information for this language...
>>> print browser. getLink( id='plural_ question' ).url answers. launchpad. dev/rosetta/ +addquestion
http://
We will see a note that this language is not registred as being spoken in any
country and a link to add question page for informating Rosetta admin about the
countries where this page is officially spoken.
>>> countries_portlet = find_portlet( browser. contents, 'Countries')
>>> print countries_portlet
<...
Abkhazian is not registered as being spoken in any
country...
>>> print browser. getLink( id='country_ question' ).url answers. launchpad. dev/rosetta/ +addquestion
http://
== lint ==
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files: translations/ browser/ language. py translations/ stories/ standalone/ xx-language. txt translations/ templates/ language- index.pt
lib/lp/
lib/lp/
lib/lp/