= Bug 127171 =

A Translations Expert (or Rosetta Admin, or the other way around) cannot access the "Change translators" page.

For example, if he/she goes to: https://translations.launchpad.net/pmount/+translations, the Change translators option is shown, but clicking it result in:

  Not allowed here
  Sorry, you don't have permission to access this page.
  You are logged in as [...]

== Proposed fix ==

Allow Rosetta Admins to edit translation options for a project, a product and a distribution.

== Pre-implementation notes ==

After the fix for bug #422056 landed on edge, the Change translator page has been generalized and it does not include only option to change translations.
Talking with Danilo we decided to rename this page to +settings (see bug 516317).

Talking with Danilo, and as noted in the bug comments, Rosetta Experts should have access to both Product and Distribution settings. Translation group owners should not be able to edit project translation settings.

While Ubuntu is the only distribution using Launchpad Translations, the owners of a translation group will have access only to distributions (to help Ubuntu Translations Coordinators) not to projects using that translation group.

Talking with Jeroen, we decided to rename IHasTranslationGroup to ITranslationPolicy as it makes more sense.

== Implementation details ==
Since we are going to add more pagetests for Rosetta Experts, I have added setupRosettaExpertBrowser() to simplify such tests. I have also improved the previous code for creating a translation group owner browser.

The launchpad.TranslationAdmin permission was added for IProduct, IProject and IDistribution allowing Launchpad Admin, Rosetta Admins and owners to edit translation related attributes.

I did not touch the code popping in the lint warnings. Any advice for fixing them is much appreciated.

== Tests ==
lp-test -t permission -t policy

== Demo and Q/A ==
Log in as Rosetta admin (ex <email address hidden>).

Go to a product or project translations page:
ie. https://translations.launchpad.dev/evolution
https://translations.launchpad.dev/gnome

You should see the „Change permissions” link, be able to access the page and change the values from that page.

Same story for a distribution page:
https://translations.launchpad.dev/ubuntu

Login as a normal user you should not be able to see the link of edit the page.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/canonical/launchpad/security.py
  lib/canonical/launchpad/testing/pages.py
  lib/lp/registry/configure.zcml
  lib/lp/registry/browser/product.py
  lib/lp/registry/interfaces/distribution.py
  lib/lp/registry/interfaces/product.py
  lib/lp/registry/interfaces/project.py
  lib/lp/translations/browser/configure.zcml
  lib/lp/translations/browser/distribution.py
  lib/lp/translations/browser/potemplate.py
  lib/lp/translations/browser/product.py
  lib/lp/translations/browser/project.py
  lib/lp/translations/browser/translationgroup.py
  lib/lp/translations/interfaces/translationgroup.py
  lib/lp/translations/stories/translationgroups/46-test-distro-structured-permissions.txt
  lib/lp/translations/stories/translationgroups/xx-change-translation-policy.txt
  lib/lp/translations/templates/distribution-language-pack-admin-info.pt
  lib/lp/translations/templates/hastranslationgroup-portlet-translation-groups-and-permission.pt


== Pylint notices ==

lib/canonical/launchpad/testing/pages.py
    42: [F0401] Unable to import 'lazr.restful.testing.webservice' (No module named restful)

lib/lp/registry/browser/product.py
    54: [F0401] Unable to import 'lazr.delegates' (No module named delegates)

lib/lp/registry/interfaces/distribution.py
    224: [C0301] Line too long (79/78)
    26: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
    27: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)
    28: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful)

lib/lp/registry/interfaces/product.py
    34: [F0401] Unable to import 'lazr.enum' (No module named enum)
    72: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
    73: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)
    74: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful)
    778: [C0322, IProductSet.createProduct] Operator not preceded by a space
    freshmeatproject='freshmeat_project', wikiurl='wiki_url',
    ^
    downloadurl='download_url',
    sourceforgeproject='sourceforge_project',
    programminglang='programming_lang')
    @export_factory_operation(
    IProduct, ['name', 'displayname', 'title', 'summary', 'description',
    'project', 'homepageurl', 'screenshotsurl',
    'downloadurl', 'freshmeatproject', 'wikiurl',
    'sourceforgeproject', 'programminglang',
    'license_reviewed', 'licenses', 'license_info',
    'registrant'])
    @export_operation_as('new_project')
    def createProduct(owner, name, displayname, title, summary,
    description=None, project=None, homepageurl=None,
    screenshotsurl=None, wikiurl=None,
    downloadurl=None, freshmeatproject=None,
    sourceforgeproject=None, programminglang=None,
    license_reviewed=False, mugshot=None, logo=None,
    icon=None, licenses=None, license_info=None,
    registrant=None):

lib/lp/registry/interfaces/project.py
    48: [F0401] Unable to import 'lazr.restful.fields' (No module named restful)
    49: [F0401] Unable to import 'lazr.restful.declarations' (No module named restful)

lib/lp/translations/interfaces/translationgroup.py
    25: [F0401] Unable to import 'lazr.enum' (No module named enum)