Merge lp:~adeuring/launchpadlib/wadl_info_hwdrivername into lp:~launchpad-pqm/launchpadlib/devel

Proposed by Abel Deuring
Status: Superseded
Proposed branch: lp:~adeuring/launchpadlib/wadl_info_hwdrivername
Merge into: lp:~launchpad-pqm/launchpadlib/devel
Diff against target: None lines
To merge this branch: bzr merge lp:~adeuring/launchpadlib/wadl_info_hwdrivername
Reviewer Review Type Date Requested Status
Robert Collins (community) Needs Information
Graham Binns (community) Approve
Review via email:

This proposal has been superseded by a proposal from 2011-11-16.

To post a comment you must log in.
Revision history for this message
Abel Deuring (adeuring) wrote :

This branch updates wadl-to-refhtml.xsl for the new classes IHWDriverName and IHWDriverPackageName

Revision history for this message
Graham Binns (gmb) wrote :

> === modified file 'src/launchpadlib/wadl-to-refhtml.xsl'
> --- src/launchpadlib/wadl-to-refhtml.xsl 2009-01-18 21:16:29 +0000
> +++ src/launchpadlib/wadl-to-refhtml.xsl 2009-06-09 14:17:50 +0000
> @@ -279,6 +279,14 @@
> <xsl:text>/+hwdb/+hwvendorid/</xsl:text>
> <var>&lt;id&gt;</var>
> </xsl:when>
> + <xsl:when test="@id = 'h_w_driver_name'">
> + <xsl:text>/+hwdb/+drivername/</xsl:text>
> + <var>&lt;name&gt;</var>
> + </xsl:when>
> + <xsl:when test="@id = 'h_w_driver_package_name'">
> + <xsl:text>/+hwdb/+driverpackagename/</xsl:text>
> + <var>&lt;package_name&gt;</var>
> + </xsl:when>

I really don't like the fact that there are no tests for these changes
save for watching the output of make build. Please file a bug (on lplib,
I think) about the fact that it would be nice to have a way to test

 review approve
 status approved

review: Approve
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

On Tuesday 09 June 2009, Graham Binns wrote:
> Review: Approve

The merging of that branch was bounced because of an unrelated failure.

Please don't submit it for merging again. It wouldn't be used by Launchpad to
generate the WADL anyway because launchpadlib is now packaged through buildout
and doesn't use the sourcecode branch anymore.

I need to sort out this problem. I'll make sure to merge that changes in once
it's dealt with.

Sorry for the trouble.

Francis J. Lacoste
<email address hidden>

Revision history for this message
Robert Collins (lifeless) wrote :

Francis, is this now done-or-irrelevant?

review: Needs Information

Unmerged revisions

42. By Abel Deuring

Entries for IHWDriverName and IHWDriverPackageName added to wadl-to-refhtml.xsl

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/launchpadlib/wadl-to-refhtml.xsl'
2--- src/launchpadlib/wadl-to-refhtml.xsl 2009-01-18 21:16:29 +0000
3+++ src/launchpadlib/wadl-to-refhtml.xsl 2009-06-09 14:17:50 +0000
4@@ -279,6 +279,14 @@
5 <xsl:text>/+hwdb/+hwvendorid/</xsl:text>
6 <var>&lt;id&gt;</var>
7 </xsl:when>
8+ <xsl:when test="@id = 'h_w_driver_name'">
9+ <xsl:text>/+hwdb/+drivername/</xsl:text>
10+ <var>&lt;name&gt;</var>
11+ </xsl:when>
12+ <xsl:when test="@id = 'h_w_driver_package_name'">
13+ <xsl:text>/+hwdb/+driverpackagename/</xsl:text>
14+ <var>&lt;package_name&gt;</var>
15+ </xsl:when>
16 <xsl:when test="@id = 'jabber_id'">
17 <xsl:text>/</xsl:text>
18 <var>&lt;;</var>


People subscribed via source and target branches