Merge lp:~adeuring/launchpad/sec-adapter-projectgroup-milestone into lp:launchpad
Proposed by
Abel Deuring
Status: | Merged |
---|---|
Approved by: | Aaron Bentley |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16180 |
Proposed branch: | lp:~adeuring/launchpad/sec-adapter-projectgroup-milestone |
Merge into: | lp:launchpad |
Diff against target: |
175 lines (+137/-2) 3 files modified
lib/lp/registry/configure.zcml (+2/-1) lib/lp/registry/tests/test_milestone.py (+126/-1) lib/lp/security.py (+9/-0) |
To merge this branch: | bzr merge lp:~adeuring/launchpad/sec-adapter-projectgroup-milestone |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Aaron Bentley (community) | Approve | ||
Review via email:
|
Commit message
privacy aware security adapter for IProjectGroupMi
Description of the change
This branch adds a security adapter for project milestones.
We want to keep data from private products completely private,
this includes also class ProjectMilestone, the "project
representation" of milestones for products.
The changes are simple:
- require the permission launchpad.View for all properties of
IProjectGroup
- delegate the authorization to the parent product.
tests:
./bin/test -vvt lp.registry.
no lint
To post a comment you must log in.