Merge lp:~adeuring/launchpad/product-lp-limitedview-branch-view into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Abel Deuring |
Approved revision: | no longer in the source branch. |
Merged at revision: | 16273 |
Proposed branch: | lp:~adeuring/launchpad/product-lp-limitedview-branch-view |
Merge into: | lp:launchpad |
Diff against target: |
148 lines (+56/-14) 4 files modified
lib/lp/blueprints/browser/tests/test_specification.py (+20/-0) lib/lp/code/browser/tests/test_branch.py (+22/-0) lib/lp/registry/interfaces/product.py (+12/-12) lib/lp/registry/tests/test_product.py (+2/-2) |
To merge this branch: | bzr merge lp:~adeuring/launchpad/product-lp-limitedview-branch-view |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Harding (community) | Approve | ||
Review via email: mp+134315@code.launchpad.net |
Commit message
tests to ensure that users with an artifacts grant for branches and specifications related to aprivate projects can access the LP pages for these branches/specs. IHasIcon moved from IProductView to IProductLimitedView
Description of the change
This branch adds tests to show that users having only an artifact
grant for blueprint or a branch related to a private product can
access the related LP pages.
The test for the branch failed at first because access to IProduct.icon
is required, so I made IHasIcon a base class of IProductLimitedView
instead of IProductView.
tests:
./bin/test blueprints -vvt test_view_
./bin/test code -vvt test_view_
no lint
#64 typo: Unaut[h]orized