Merge lp:~adeuring/launchpad/bug-829074-ui into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Graham Binns | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 14755 | ||||
Proposed branch: | lp:~adeuring/launchpad/bug-829074-ui | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
184 lines (+91/-17) 4 files modified
lib/lp/bugs/browser/bugtask.py (+22/-8) lib/lp/bugs/browser/tests/test_buglisting.py (+31/-0) lib/lp/bugs/interfaces/bugtask.py (+3/-0) lib/lp/bugs/templates/bugtask-macros-tableview.pt (+35/-9) |
||||
To merge this branch: | bzr merge lp:~adeuring/launchpad/bug-829074-ui | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+91796@code.launchpad.net |
Commit message
[r=gmb][bug=829074] new properties BugTaskSearchLi
Description of the change
This branch fixes bug 829074: Show bugs that are not known to affect
"official" upstream
The already merged branch lp:~adeuring/launchpad/bug-829074 has the
required changes for BugTaskSet.
minimal set of UI changes: It allows only to select the project
that is linked to a source package via the Packaging table.
I'll extend this quite simple and "narrow" interpretation of
"possibly relevant upstream" in a later branch so that users
can select a arbitrary project, or an upstream SP or DSP. The latter
can be useful when the Ubuntu upstream is not a project but
a Debian package. This should also address the quite similar
bug 232545.
The changes are straightforward:
- A new property BugTaskSearchLi
the Product linked via the packaging table if the current context
is an SP or DSP.
- A new element in the schema used by BugTaskSearchLi
IBugTaskSearc
- new UI elements in the page template.
tests:
./bin/test -vvt lp.bugs.
./bin/test -vvt lp.bugs.
./bin/test -vvt lp.bugs.
(I did not add any tests that selecting the upstream project returns the
desired search results -- this is already covered in
lp:~adeuring/launchpad/bug-829074 . But test_filter_
ensures that the form parameter field.upstream_
"mapped" to BugTaskSearchPa
No lint