Merge lp:~adeuring/launchpad/bug-739075-2 into lp:launchpad/db-devel
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Abel Deuring | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 10544 | ||||
Proposed branch: | lp:~adeuring/launchpad/bug-739075-2 | ||||
Merge into: | lp:launchpad/db-devel | ||||
Prerequisite: | lp:~adeuring/launchpad/bug-739075 | ||||
Diff against target: |
48 lines (+6/-8) 2 files modified
lib/lp/answers/model/question.py (+4/-6) lib/lp/answers/model/questionsperson.py (+2/-2) |
||||
To merge this branch: | bzr merge lp:~adeuring/launchpad/bug-739075-2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Review via email: mp+60768@code.launchpad.net |
Commit message
[r=allenap][bug=739075] do not join Message in QuestionMessage related queries in order to find the owner of the message; use the new column QuestionMessage
Description of the change
This branch should fix bug 739075: Person:+questions timeouts. An
EXPLAIN ANALYZE for the long queries from the OOPS reports mentioned
in this bug show that much time is spent joining QuestionMessage and
the huge table Message.
The prerequisite branch lp:~adeuring/launchpad/bug-739075 adds the
column owner to QuestionMessage; similar to BugMessage. The content
of this column is a copy of questionmessage
The branch removes joins of Message in queries in
lp.answers.
it replaces terms like "Message.
"QuestionMessag
Tests:
./bin/test answers -vv
(sorry, I did not bother to check which tests are actually necessary
-- answers related tests needed less than 5 minutes on my machine.)
no lint