Merge lp:~adeuring/launchpad/bug-598484 into lp:launchpad

Proposed by Abel Deuring
Status: Merged
Approved by: Deryck Hodge
Approved revision: no longer in the source branch.
Merged at revision: 11064
Proposed branch: lp:~adeuring/launchpad/bug-598484
Merge into: lp:launchpad
Diff against target: 34 lines (+14/-0)
2 files modified
lib/lp/bugs/browser/configure.zcml (+6/-0)
lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt (+8/-0)
To merge this branch: bzr merge lp:~adeuring/launchpad/bug-598484
Reviewer Review Type Date Requested Status
Deryck Hodge (community) code Approve
Review via email: mp+28505@code.launchpad.net

Description of the change

This branch fixes bug 598484 which I caused in my branch for bug 583385. I simply forgot that IHasBugs was not only implemented by IBugTarget and IPerson, but also by IProjectGroup.

So I added another ZCML directive that defines the currently missing page again for project groups.

test: ./bin/test -t xx-bug-text-pages.txt

no lint

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

Thanks for making this change so quickly, Abel. Looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/bugs/browser/configure.zcml'
2--- lib/lp/bugs/browser/configure.zcml 2010-06-18 10:41:48 +0000
3+++ lib/lp/bugs/browser/configure.zcml 2010-06-25 13:44:30 +0000
4@@ -59,6 +59,12 @@
5 name="+bugs-text"
6 attribute="__call__"/>
7 <browser:page
8+ for="lp.registry.interfaces.projectgroup.IProjectGroup"
9+ class="lp.bugs.browser.bugtask.TextualBugTaskSearchListingView"
10+ permission="zope.Public"
11+ name="+bugs-text"
12+ attribute="__call__"/>
13+ <browser:page
14 for="lp.bugs.interfaces.bugtarget.IHasBugs"
15 class="lp.bugs.browser.bugtask.BugTaskSearchListingView"
16 permission="zope.Public"
17
18=== modified file 'lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt'
19--- lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt 2010-06-03 21:49:47 +0000
20+++ lib/lp/bugs/stories/bugs/xx-bug-text-pages.txt 2010-06-25 13:44:30 +0000
21@@ -281,6 +281,14 @@
22 >>> print anon_browser.contents
23 10
24
25+This page is also available for project groups.
26+
27+ >>> anon_browser.open('http://launchpad.dev/mozilla/+bugs-text')
28+ >>> print anon_browser.contents
29+ 15
30+ 5
31+ 4
32+
33
34 == Private bugs ==
35