Merge lp:~adeuring/launchpad/bug-596944-schema into lp:launchpad/db-devel

[Abel Deuring]

[r=stub][ui=none][bug=596944] Add a column enable_bugfiling_duplicate_search to the tables Product and DistributionSourcePackage.

See bug 596944 and https://dev.launchpad.net/LEP/DisableFilebugDuplicateSearchOption :
For some projects and source package a search for duplicate during bug filing is doing more harm than helping. This branch adds a column "file_bug_duplicate_search" to the tables Product and DistributionSourcePackage.

[Robert Collins (lifeless)]

The column name is a bit opaque. Lets make it clearer - e.g.
'disable_bugfiling_duplicate_search'.

-Rob

[Abel Deuring (adeuring)]

On 22.11.2010 18:16, Robert Collins wrote:
> The column name is a bit opaque. Lets make it clearer - e.g.
> 'disable_bugfiling_duplicate_search'.

Changed

[Stuart Bishop (stub)]

If we want to be consistent though, it should be enable_bugfiling_duplicate_search (closest match in the current schema is enable_bugtask_expiry). We have no disable_* or *_disabled columns. I'd prefer the consistent enable_ name.

Setting the default should be fine with our current downtime windows - 35k distributionsourcepackage and 27k product records to rewrite.

Please add the following to the end of the patch to repack these tables:

CLUSTER DistributionSourcePackage USING distributionpackage__sourcepackagename__distribution__key;
CLUSTER Product USING product_name_key;

patch-2208-31-0.sql

review: Approve (db)

=== modified file 'database/schema/comments.sql'
--- database/schema/comments.sql	2010-10-26 16:22:57 +0000
+++ database/schema/comments.sql	2010-11-24 09:30:57 +0000
@@ -527,6 +527,7 @@
 COMMENT ON COLUMN DistributionSourcePackage.po_message_count IS 'Number of translations matching the package distribution and sourcepackagename. NULL means it has not yet been calculated.';
 COMMENT ON COLUMN DistributionSourcePackage.is_upstream_link_allowed IS 'Whether an upstream link may be added if it does not already exist.';
 COMMENT ON COLUMN DistributionSourcePackage.bug_reported_acknowledgement IS 'A message of acknowledgement to display to a bug reporter after they\'ve reported a new bug.';
+COMMENT ON COLUMN DistributionSourcePackage.enable_bugfiling_duplicate_search IS 'Enable/disable a search for posiible duplicates when a bug is filed.';
 
 -- DistributionSourcePackageCache
 
@@ -711,7 +712,7 @@
 COMMENT ON COLUMN Product.max_bug_heat IS 'The highest heat value across bugs for this product.';
 COMMENT ON COLUMN Product.date_next_suggest_packaging IS 'The date when Launchpad can resume suggesting Ubuntu packages that the project provides.';
 COMMENT ON COLUMN Product.bug_reported_acknowledgement IS 'A message of acknowledgement to display to a bug reporter after they\'ve reported a new bug.';
-
+COMMENT ON COLUMN Product.enable_bugfiling_duplicate_search IS 'Enable/disable a search for posiible duplicates when a bug is filed.';
 
 -- ProductLicense
 COMMENT ON TABLE ProductLicense IS 'The licenses that cover the software for a product.';

=== added file 'database/schema/patch-2208-31-0.sql'
--- database/schema/patch-2208-31-0.sql	1970-01-01 00:00:00 +0000
+++ database/schema/patch-2208-31-0.sql	2010-11-24 09:30:57 +0000
@@ -0,0 +1,16 @@
+-- Copyright 2010 Canonical Ltd.  This software is licensed under the
+-- GNU Affero General Public License version 3 (see the file LICENSE).
+SET client_min_messages=ERROR;
+
+ALTER TABLE Product
+    ADD COLUMN enable_bugfiling_duplicate_search
+        BOOLEAN NOT NULL DEFAULT True;
+ALTER TABLE DistributionSourcePackage
+    ADD COLUMN enable_bugfiling_duplicate_search
+        BOOLEAN NOT NULL DEFAULT True;
+
+CLUSTER DistributionSourcePackage USING
+    distributionpackage__sourcepackagename__distribution__key;
+CLUSTER Product USING product_name_key;
+
+INSERT INTO LaunchpadDatabaseRevision VALUES (2208, 31, 0);