Merge lp:~adeuring/launchpad/bug-550973 into lp:launchpad

[Abel Deuring]

This branch just adds a comment why we don't require a referer header for POSTs to /+hwdb/+submit. See bug 550973

[Deryck Hodge (deryck)]

I hope Gary won't mind, but I want to step in and review here. I believe I understand what he's looking for in terms of a comment, and we need to move this branch forward on our kanban board.

With that in mind, this looks good to me and I'm marking it approved.

review: Approve (code)

[Gary Poster (gary)]

Looks good, and sorry for not getting to it sooner.

review: Approve

=== modified file 'lib/canonical/launchpad/webapp/publication.py'
--- lib/canonical/launchpad/webapp/publication.py	2010-04-08 10:43:26 +0000
+++ lib/canonical/launchpad/webapp/publication.py	2010-04-12 11:03:27 +0000
@@ -343,6 +343,12 @@
             # +request-token and +access-token without providing a
             # Referer.
             #
+            # XXX Abel Deuring 2010-04-09 bug=550973
+            # The HWDB client "checkbox" accesses /+hwdb/+submit without
+            # a referer. This will change in the version in Ubuntu 10.04,
+            # but Launchpad should support HWDB submissions from older
+            # Ubuntu versions during their support period.
+            #
             # We'll have to keep an application's one-off exception
             # until the application has been changed to send a
             # Referer, and until we have no legacy versions of that