Merge lp:~adeuring/launchpad/bug-528374 into lp:launchpad/db-devel
Proposed by
Abel Deuring
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Graham Binns | ||||||||
Approved revision: | not available | ||||||||
Merged at revision: | not available | ||||||||
Proposed branch: | lp:~adeuring/launchpad/bug-528374 | ||||||||
Merge into: | lp:launchpad/db-devel | ||||||||
Diff against target: |
58 lines (+19/-4) 2 files modified
lib/lp/bugs/browser/bugtask.py (+7/-3) lib/lp/bugs/browser/tests/bug-heat-view.txt (+12/-1) |
||||||||
To merge this branch: | bzr merge lp:~adeuring/launchpad/bug-528374 | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+20232@code.launchpad.net |
To post a comment you must log in.
This branch fixes bug 528374: Flames misplaced on bug report page
It was caused by the removal of a <span> that enclosed the <img> tags of heat icons. I have not enough CSS-fu to explain why this <span> necessary...
As a drive-by fix, I ensured that a case like "7 out of 4 heat flames" (as can be currently seen on https:/ /bugs.edge. launchpad. net/ubuntu/ +bugs?orderby= -heat can no longer occur and that a max_heat value of 1 does not cause a divide-by-zero error.
test: ./bin/test -t bug-heat-view.txt
To check the position of haet icon: Open https:/ /bugs.launchpad .dev/firefox/ +bug/1 ; the icons should appear right of "Bug #1 reported by Sample Person on 2004-01-01"
no lint