Merge lp:~adeuring/launchpad/bug-333521-allow-mail-to-question-subscribers into lp:launchpad/db-devel

[Abel Deuring]

A test run of the bug expiration script (cronscripts/expire-bugtasks.py) ended with an exception, caused by insufficient permissions of the DB user or this script. If a question is linked to a bug, subscribers to the question are notified about bug task status changes, and the DB user "bugnotification" needs access to several tables related to questions, parsons and languages in order to create the notification emails.

This branch adds the missing permissions and a unit test that ensures that the notification mails are properly created.

test: ./bin/test -vvt test_bugnotification

no lint

[Jeroen T. Vermeulen (jtv)]

IRC notes:
 * No need to login(); pass the email address to the TestCaseWithFactory constructor instead.
 * No need to set up product_owner separately; might as well let makeProduct do that.
 * Don't make your test comparison rely on the ordering of the recipients list.
 * What is a "sub" as mentioned in the test docstring?
 * Don't say "Ensure that" in tests. Ensuring things is what tests do.
 * Don't hard-code persons' names and email addresses when all you want to do is compare for equality.

You've addressed all of these. Thanks for that!

Jeroen

review: Approve

=== modified file 'database/schema/security.cfg'
--- database/schema/security.cfg	2010-04-19 22:16:10 +0000
+++ database/schema/security.cfg	2010-04-21 09:52:01 +0000
@@ -1239,6 +1239,7 @@
 type=user
 groups=script
 public.account                          = SELECT
+public.answercontact                    = SELECT
 public.archive                          = SELECT
 public.archivearch                      = SELECT
 public.bugnotification                  = SELECT, INSERT, UPDATE
@@ -1257,11 +1258,13 @@
 public.component                        = SELECT
 public.packagebugsupervisor             = SELECT
 public.person                           = SELECT
+public.personlanguage                   = SELECT
 public.product                          = SELECT
 public.project                          = SELECT
 public.productseries                    = SELECT
 public.question                         = SELECT
 public.questionbug                      = SELECT
+public.questionsubscription             = SELECT
 public.distribution                     = SELECT
 public.distributionsourcepackage        = SELECT, INSERT, UPDATE
 public.distroseries                     = SELECT
@@ -1279,6 +1282,7 @@
 public.teamparticipation                = SELECT
 public.validpersoncache                 = SELECT
 public.validpersonorteamcache           = SELECT
+public.language                         = SELECT
 
 [personnotification]
 type=user

=== modified file 'lib/lp/bugs/tests/test_bugnotification.py'
--- lib/lp/bugs/tests/test_bugnotification.py	2009-06-25 00:40:31 +0000
+++ lib/lp/bugs/tests/test_bugnotification.py	2010-04-21 09:52:01 +0000
@@ -12,12 +12,15 @@
 
 from lazr.lifecycle.snapshot import Snapshot
 
+from canonical.config import config
 from canonical.launchpad.database import BugNotification
 from lazr.lifecycle.event import ObjectModifiedEvent
 from canonical.launchpad.ftests import login
-from lp.bugs.interfaces.bugtask import BugTaskStatus
+from lp.bugs.interfaces.bugtask import BugTaskStatus, IUpstreamBugTask
+from lp.testing import TestCaseWithFactory
 from lp.testing.factory import LaunchpadObjectFactory
-from canonical.testing import LaunchpadFunctionalLayer
+from lp.testing.mail_helpers import pop_notifications
+from canonical.testing import LaunchpadFunctionalLayer, LaunchpadZopelessLayer
 
 
 class TestNotificationRecipientsOfPrivateBugs(unittest.TestCase):
@@ -80,6 +83,42 @@
         self.assertEqual(notified_people, self.direct_subscribers)
 
 
+class TestNotificationsSentForBugExpiration(TestCaseWithFactory):
+    """Ensure that question subscribers are notified about bug expiration."""
+
+    layer = LaunchpadZopelessLayer
+
+    def setUp(self):
+        super(TestNotificationsSentForBugExpiration, self).setUp(
+            user='[e-mail]')
+        # We need a product, a bug for this product, a question linked
+        # to the bug and a subscriber.
+        self.product = self.factory.makeProduct()
+        self.bug = self.factory.makeBug(product=self.product)
+        question = self.factory.makeQuestion(target=self.product)
+        self.subscriber = self.factory.makePerson()
+        question.subscribe(self.subscriber)
+        question.linkBug(self.bug)
+        # Flush pending notifications for question creation.
+        pop_notifications()
+        self.layer.switchDbUser(config.malone.expiration_dbuser)
+
+    def test_notifications_for_question_subscribers(self):
+        # Ensure that notifications are sent to subscribers of a
+        # question linked to the expired bug.
+        bugtask = self.bug.default_bugtask
+        bugtask_before_modification = Snapshot(
+            bugtask, providing=IUpstreamBugTask)
+        bugtask.transitionToStatus(BugTaskStatus.EXPIRED, self.product.owner)
+        bug_modified = ObjectModifiedEvent(
+            bugtask, bugtask_before_modification, ["status"])
+        notify(bug_modified)
+        self.assertContentEqual(
+            [self.product.owner.preferredemail.email,
+             self.subscriber.preferredemail.email],
+            [mail['To'] for mail in pop_notifications()])
+
+
 def test_suite():
     """Return the test suite for the tests in this module."""
     return unittest.TestLoader().loadTestsFromName(__name__)