Merge ~addyess/charm-sudo-pair:lp1863743-run_action_updates_workload_status into charm-sudo-pair:master

[Adam Dyess]

[Bug 1863743] Resolve issue where workload status isn't updated after remove-sudopair action

[Ryan Farrell (whereisrysmind)]

Nice unit test, Looks good. +1

review: Approve

[Adam Dyess (addyess)]

CI Results: https://paste.ubuntu.com/p/jrymNswrnn/

[Chris Sanders (chris.sanders)]

lgtm

review: Approve

diff --git a/actions/actions.py b/actions/actions.py
index ccf3ffc..1cb455c 100755
--- a/actions/actions.py
+++ b/actions/actions.py
@@ -16,7 +16,7 @@
 import os
 import sys
 
-from charmhelpers.core.hookenv import action_fail, action_set
+from charmhelpers.core.hookenv import action_fail, action_set, status_set
 
 
 sys.path.append("lib")
@@ -28,7 +28,9 @@ def remove():
     """Remove sudo-pair config and binaries."""
     sph = libsudopair.SudoPairHelper()
     sph.deconfigure()
-    action_set({"message": "Successfully removed sudo-pair config and binaries"})
+    msg = "Successfully removed sudo-pair config and binaries"
+    action_set({"message": msg})
+    status_set('active', msg)
 
 
 # A dictionary of all the defined actions to callables (which take
diff --git a/tests/unit/test_actions.py b/tests/unit/test_actions.py
new file mode 100644
index 0000000..c2da297
--- /dev/null
+++ b/tests/unit/test_actions.py
@@ -0,0 +1,17 @@
+import os
+import sys
+import unittest.mock as mock
+action_path = os.path.join(os.path.dirname(__file__), '..', '..', 'actions')
+sys.path.append(action_path)
+import actions # NOQA
+
+
[e-mail]('libsudopair.SudoPairHelper')
[e-mail]('actions.action_set')
[e-mail]('actions.status_set')
+def test_remove_action(status_set, action_set, sudo_pair_helper):
+    actions.remove()
+    msg = 'Successfully removed sudo-pair config and binaries'
+    action_set.assert_called_with({'message': msg})
+    status_set.assert_called_with('active', msg)
+    sudo_pair_helper().deconfigure.assert_called()