Merge ~addyess/charm-nagios:test/swap_mysql_to_percona into ~nagios-charmers/charm-nagios:master

Proposed by Adam Dyess
Status: Rejected
Rejected by: Giuseppe Petralia
Proposed branch: ~addyess/charm-nagios:test/swap_mysql_to_percona
Merge into: ~nagios-charmers/charm-nagios:master
Diff against target: 26 lines (+4/-4)
1 file modified
tests/functional/ (+4/-4)
Reviewer Review Type Date Requested Status
Paul Goins Needs Fixing
Drew Freiberger (community) Approve
Review via email:
To post a comment you must log in.
Revision history for this message
Adam Dyess (addyess) wrote :
Revision history for this message
Drew Freiberger (afreiberger) wrote :


review: Approve
Revision history for this message
Paul Goins (vultaire) wrote :

I'm not sure the updated relations are correct. Manual testing in a test model gives me errors when I try to wire things in the way done here.

review: Needs Fixing
Revision history for this message
Giuseppe Petralia (peppepetra) wrote :

Unmerged commits

0f0ff98... by Adam Dyess

Change out mysql-charm to percona-cluster-charm

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/functional/ b/tests/functional/
2index fafe7f0..d607a62 100644
3--- a/tests/functional/
4+++ b/tests/functional/
5@@ -200,8 +200,8 @@ async def relatives(model):
7 mysql = "mysql"
8 mysql_app = await model.deploy(
9- 'cs:' + mysql, application_name=mysql,
10- series='trusty', config={}
11+ 'cs:percona-cluster', application_name=mysql,
12+ series='bionic', config={}
13 )
15 mediawiki = "mediawiki"
16@@ -237,8 +237,8 @@ async def deploy_app(relatives, model, series):
17 'enable_pagerduty': False
18 }
19 )
20- await model.add_relation('{}:monitors'.format(app_name), 'mysql:monitors')
21- await model.add_relation('{}:nagios'.format(app_name), 'mediawiki:juju-info')
22+ for relative in relatives.keys():
23+ await model.add_relation(app_name + ':nagios', relative + ':juju-info')
24 await model.add_relation('nrpe:monitors', '{}:monitors'.format(app_name))
25 await model.block_until(lambda: nagios_app.status == "active")
26 await model.block_until(lambda: all(


People subscribed via source and target branches