Merge lp:~adamse123/update-manager/include-pkg-name-in-package-list into lp:update-manager

Proposed by A
Status: Needs review
Proposed branch: lp:~adamse123/update-manager/include-pkg-name-in-package-list
Merge into: lp:update-manager
Diff against target: 19 lines (+4/-4)
1 file modified
UpdateManager/Core/utils.py (+4/-4)
To merge this branch: bzr merge lp:~adamse123/update-manager/include-pkg-name-in-package-list
Reviewer Review Type Date Requested Status
Łukasz Zemczak Needs Fixing
Review via email: mp+430577@code.launchpad.net

Description of the change

Includes the package name in the line in the "Details of updates" pane.

For eg "lldb" it currently says "Next generation, high-performance debugger", giving no clue to what package is being updated. This patch prefixes it with "lldb: ".

To post a comment you must log in.
2950. By A

include package name in updates listing

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Thank you for your contribution! I think this makes sense indeed. Would be nice if someone from the update-manager maintainers could also take a look at this, but IMO it's a good change. I'd tweak it though before continuing as per my inline comment.

review: Needs Fixing

Unmerged revisions

2950. By A

include package name in updates listing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UpdateManager/Core/utils.py'
2--- UpdateManager/Core/utils.py 2019-04-08 17:00:30 +0000
3+++ UpdateManager/Core/utils.py 2022-09-27 19:27:32 +0000
4@@ -552,11 +552,11 @@
5
6
7 def get_package_label(pkg):
8- """ this takes a package synopsis and uppercases the first word's
9- first letter
10+ """ this takes a package name and adds to it the package synopsis where the
11+ first word's letter is uppercased
12 """
13- name = getattr(pkg.candidate, "summary", "")
14- return capitalize_first_word(name)
15+ summary = getattr(pkg.candidate, "summary", "")
16+ return pkg.name + ": " + capitalize_first_word(summary)
17
18
19 if __name__ == "__main__":

Subscribers

People subscribed via source and target branches

to status/vote changes: