lp:~adamreichold/qpdfview/extend-search-dock2

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~srazi/qpdfview/extend-search-dock2 at revision 1707

Razi Alavizadeh: Approve on 2014-09-28

Diff: 351 lines (+82/-137)

4 files modified

sources/mainwindow.cpp (+7/-13)
sources/miscellaneous.cpp (+60/-101)
sources/miscellaneous.h (+8/-14)
sources/searchmodel.cpp (+7/-9)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

1710. By Adam Reichold <email address hidden> on 2014-09-28

Add a missing const and improve method naming.

1709. By Adam Reichold <email address hidden> on 2014-09-28

Painting a page number using the search delegate is overkill.

1708. By Adam Reichold <email address hidden> on 2014-09-28

Try to reduce the amount of boiler-plate code in the search delegate.

Since we do all the layout for each item anyway, there is no need to store these objects as members.
Hence there is no need for mutable members and we also do not need to layout several lines if we only ever paint the first one.

1707. By Adam Reichold <email address hidden> on 2014-09-28

Fix compilation issues caused by the qHash(QPair) overload being preferred over the more specific result overload.

1706. By Razi Alavizadeh on 2014-09-26

Compute containing text for search results on-demand.

1705. By Razi Alavizadeh on 2014-09-25

Correctly use prepareHighlight on click over search items.

1704. By Razi Alavizadeh on 2014-09-25

Some improvements related to the new search dock:
1- Better performance by disabling update on view and removing connection to verticalHeader sectionCountChanged.
2- Correct width for page column.
3- Use beginResetModel() and endResetModel() within SearchModel::clear()

1703. By Razi Alavizadeh on 2014-09-25

Revert regression.

1702. By Razi Alavizadeh on 2014-09-25

SearchDelegate now inherits from QStyledItemDelegate.

1701. By Razi Alavizadeh on 2014-09-24

Improved search dock, it shows found occurrences on a table.