Merge lp:~adam.russell/pyexiv2/pyexiv2-0.3 into lp:pyexiv2

[Adam]

I have added a setup.py file for you. I didn't want to touch the system you have in place with scons, though, so I worked around that. However, I (and many others, I'm sure) love the pip and virtualenv tools, and currently pyexiv2 isn't very friendly with those. This branch allows pyexiv2 to easily be installed by pip, e.g.:

pip install -e bzr+lp:~adam.russell/pyexiv2/pyexiv2-0.3#egg=pyexiv2

This branch will make things easier on any project that depends on pyexiv2, as they will be able to put it in a requirements.txt file. It's a step closer to being able to put pyexiv2 on PyPI, too, if that's something you want to do.

I should note that I only tested these changes with Python 2.7. Not sure how old of a Python version you want to support, or if that even really matters. Anyway, let me know if you have any questions about what I wrote or if there are any changes you'd like me to make.

[Olivier Tilloy (osomon)]

Thanks for your contribution Adam!

I’m not familiar with pip and virtualenv myself, but I guess making pyexiv2 more accessible to developers who use those tools can only be a good thing.

I don’t have much spare time on my hands now, but I’ll eventually review your code, thanks in advance for your patience.

I hadn’t though of publishing pyexiv2 on PyPI before (it’s already available in a number of distributions as native packages), but it can’t hurt :)

Regarding the versions of Python supported, it’s 2.6 and upwards (unfortunately Python 3 is not supported yet). When I get to testing your code I’ll make sure I test with 2.6 too.

[Hobson Lane (hobs)]

Awesome. Pip and setup.py support will makes pyexiv2 easier to integrate into Pinax and Django webapps.

[Adam (adam.russell)]

Have you had a chance to review these changes yet, by any chance?

[Olivier Tilloy (osomon)]

> Have you had a chance to review these changes yet, by any chance?

Unfortunately, no, not yet. Sorry about the delay, I hope you don’t interpret it as a lack of interest from my part, your contribution is most welcome but at the moment I can’t spare time to review it. I’ll eventually get to it…

Unmerged revisions

376. By Adam Russell <email address hidden> on 2012-03-06

Reload libexiv2python in libexiv2python.py.

375. By Adam Russell <email address hidden> on 2012-03-04

Remove relative import from libexiv2python.py.

374. By Adam Russell <email address hidden> on 2012-03-04

Add setup.py.

=== modified file '.bzrignore'
--- .bzrignore	2010-01-28 19:29:34 +0000
+++ .bzrignore	2012-03-06 02:31:21 +0000
@@ -1,3 +1,5 @@
 .sconsign.dblite
 build
 doc/_build/*
+dist
+*.egg-info

=== added file 'setup.py'
--- setup.py	1970-01-01 00:00:00 +0000
+++ setup.py	2012-03-06 02:31:21 +0000
@@ -0,0 +1,25 @@
+#!/usr/bin/env python
+
+import os
+import subprocess
+from setuptools import setup, find_packages, Extension
+
+
+orig_dir = os.getcwd()
+os.chdir(os.path.abspath(os.path.dirname(__file__)))
+subprocess.call('scons')
+os.chdir(orig_dir)
+
+setup(
+    name = "pyexiv2",
+    version = "0.3.3",
+    url = 'http://tilloy.net/dev/pyexiv2/',
+    author = 'Olivier Tilloy',
+    author_email = '[e-mail]',
+    description = 'A python binding to exiv2, the C++ library for manipulation of EXIF, IPTC and XMP image metadata.',
+    license = 'GNU GPL v2',
+    download_url = 'https://launchpad.net/pyexiv2/0.3.x/0.3.3/+download/pyexiv2-0.3.3.tar.bz2',
+    packages = find_packages('src'),
+    package_dir = {'': 'src'},
+    data_files = [('', ['build/libexiv2python.so'])],
+)

=== added file 'src/libexiv2python.py'
--- src/libexiv2python.py	1970-01-01 00:00:00 +0000
+++ src/libexiv2python.py	2012-03-06 02:31:21 +0000
@@ -0,0 +1,13 @@
+'''\
+This file is a hack to get the package working post-build but without
+requiring an actual installation. Specifically, this enables
+"development mode" installation via ``python setup.py develop``.
+
+'''
+
+import os
+import sys
+sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__),
+                                                '..', 'build')))
+reload(sys.modules['libexiv2python'])
+from libexiv2python import *