Merge lp:~adam-stokes/juju-core/docs-fix-broken-links into lp:juju-core/docs

Proposed by Adam Stokes
Status: Merged
Merged at revision: 137
Proposed branch: lp:~adam-stokes/juju-core/docs-fix-broken-links
Merge into: lp:juju-core/docs
Diff against target: 61 lines (+6/-6)
4 files modified
htmldocs/authors-testing.html (+2/-2)
htmldocs/charms-destroy.html (+1/-1)
htmldocs/getting-started.html (+1/-1)
htmldocs/howto.html (+2/-2)
To merge this branch: bzr merge lp:~adam-stokes/juju-core/docs-fix-broken-links
Reviewer Review Type Date Requested Status
William Reade (community) Approve
Review via email: mp+188260@code.launchpad.net
To post a comment you must log in.
Revision history for this message
William Reade (fwereade) wrote :

Needs a </p> after the "A service can take a while..." para. Otherwise LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'htmldocs/authors-testing.html'
2--- htmldocs/authors-testing.html 2013-09-27 14:53:30 +0000
3+++ htmldocs/authors-testing.html 2013-09-30 04:50:51 +0000
4@@ -83,7 +83,7 @@
5 &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if state == started, PASS</pre>
6
7 <p>Other generic tests may be identified, so a collection of generic tests should be the focus of an implementation.</p>
8- <p>Note that this requirement is already satisfied by Mark Mims' jenkins tester: <a class="reference external" href="http://charmtests.markmims.com/">http://charmtests.markmims.com/</a></p>
9+ <p>Note that this requirement is already satisfied by Mark Mims' jenkins tester: <a class="reference external" href="https://github.com/mmm/charmtester/">https://github.com/mmm/charmtester/</a></p>
10
11 <h2>Phase 2 - Charm Specific tests</h2>
12 <p>Charm authors will have the best insight into whether or not a charm is working properly.</p>
13@@ -357,4 +357,4 @@
14 <!--End-Scripts-->
15
16
17-</body></html>
18\ No newline at end of file
19+</body></html>
20
21=== modified file 'htmldocs/charms-destroy.html'
22--- htmldocs/charms-destroy.html 2013-09-27 14:53:30 +0000
23+++ htmldocs/charms-destroy.html 2013-09-30 04:50:51 +0000
24@@ -74,7 +74,7 @@
25 <p>Once a service is no longer required it can be removed with a simple command.</p>
26 <pre class="prettyprint">juju destroy-service &LT;service-name&GT;</pre>
27 <p class="warning"><strong>Warning!:</strong> Destroying a service which has active relations with another running service will break that relation. This can cause errors in both services, as such review and potentially destroy any relationships first if.</p>
28- <p>A service can take a while to "die", but if running a juju status reveals that the service is listed as dying, but also reports an error state, then the zombied service will still be hanging around. See <a href="troubleshooting.html#die">"Why won't it just die?" in the troubleshooting section.</a>
29+ <p>A service can take a while to "die", but if running a juju status reveals that the service is listed as dying, but also reports an error state, then the zombied service will still be hanging around.
30 <p class="note"><strong>Note:</strong> Destroying a service removes that service, but not any nodes which may have been created for it to run on. This is juju's way of preserving data to the best it's ability. See <a href="#destroy-machines">Destroying Machines</a> for additional details.</p>
31 </section>
32 <section id="destroy-units">
33
34=== modified file 'htmldocs/getting-started.html'
35--- htmldocs/getting-started.html 2013-09-27 18:13:55 +0000
36+++ htmldocs/getting-started.html 2013-09-30 04:50:51 +0000
37@@ -151,7 +151,7 @@
38
39 <pre class="prettyprint">juju bootstrap</pre>
40
41- <p class="note"><strong>Note:</strong> If you have multiple environments configured, you can choose which one to address with a particular command by adding the <code>-e</code> switch followed by the environment name, E.g. <code>-e hpcloud</code>. Read more about <a href="config-environments.html">environment switching</a></p>
42+ <p class="note"><strong>Note:</strong> If you have multiple environments configured, you can choose which one to address with a particular command by adding the <code>-e</code> switch followed by the environment name, E.g. <code>-e hpcloud</code>.</p>
43
44 <p>You may have to wait a few moments for this command to return, as it needs to perform various tasks and contact your cloud provider. </p>
45 <p>Assuming it returns successfully (otherwise see <a href="#errors">common error messages and what to do about them</a>), we can now deploy some services and explore the basic operations of Juju.</p>
46
47=== modified file 'htmldocs/howto.html'
48--- htmldocs/howto.html 2013-09-27 14:53:30 +0000
49+++ htmldocs/howto.html 2013-09-30 04:50:51 +0000
50@@ -72,9 +72,9 @@
51 <p>Juju is not all about marvelling about how great service orchestration is, it's actually about getting things done. While the documentation provides you with instructions on how Juju works, this section is all about putting those commands together to do something useful. Prepare to get things done! </p>
52 <ul>
53 <li><a href="howto-node.html">Deploying a Node.js application</a></li>
54- <li><a href="howto-node.html">Deploying with the Rails framework</a></li>
55+ <li><a href="howto-rails.html">Deploying with the Rails framework</a></li>
56 </ul>
57- <p>Got an idea for something to add to add here? Check out <a href="contributing.html">how to contribute to the docs</a></p>
58+ <p>Got an idea for something to add here? Check out <a href="contributing.html">how to contribute to the docs</a></p>
59
60
61 </section>

Subscribers

People subscribed via source and target branches