Code review comment for lp:~adam-disc0tech/ubuntu-autopilot-tests/fileroller

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Thanks for the merge Adam. I have a few questions;

We can't use sudo in a test; this are non-interactive, and I'm confused why you would need root anyway. However, the symbolic linking to /home is very confusing to me; what are you trying to accomplish?

Adding logging and the 'check the files have actually been extracted' are both welcome additions.

review: Needs Fixing

« Back to merge proposal