Merge lp:~adam-davies/granite/fix-1071944 into lp:~elementary-pantheon/granite/granite

Proposed by Adam Davies
Status: Merged
Merged at revision: 455
Proposed branch: lp:~adam-davies/granite/fix-1071944
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 71 lines (+40/-14)
1 file modified
lib/Widgets/Welcome.vala (+40/-14)
To merge this branch: bzr merge lp:~adam-davies/granite/fix-1071944
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Review via email: mp+134598@code.launchpad.net

Description of the change

To post a comment you must log in.
lp:~adam-davies/granite/fix-1071944 updated
458. By Adam Davies <email address hidden>

Fixed code style

459. By Adam Davies <email address hidden>

Replaced tabs with spaces

460. By Adam Davies <email address hidden>

Fixed typo

Revision history for this message
Victor Martinez (victored) wrote :

Looks perfect to me. Thank you!

review: Approve
lp:~adam-davies/granite/fix-1071944 updated
461. By Adam Davies <email address hidden>

Fixed whitespace

462. By Adam Davies <email address hidden>

Code style change

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/Welcome.vala'
2--- lib/Widgets/Welcome.vala 2012-11-10 21:41:04 +0000
3+++ lib/Widgets/Welcome.vala 2012-11-16 03:13:20 +0000
4@@ -39,7 +39,33 @@
5 * Box for action items
6 */
7 protected Gtk.Box options;
8-
9+
10+ /**
11+ * This is the title of the welcome widget.
12+ */
13+ public string title {
14+ get {
15+ return title_label.get_label ();
16+ }
17+ set {
18+ title_label.set_label (value);
19+ }
20+ }
21+
22+ /**
23+ * This is the subtitle of the welcome widget.
24+ */
25+ public string subtitle {
26+ get {
27+ return subtitle_label.get_label ();
28+ }
29+ set {
30+ subtitle_label.set_label (value);
31+ }
32+ }
33+
34+ private Gtk.Label title_label;
35+ private Gtk.Label subtitle_label;
36 /**
37 * Makes new Welcome Page
38 *
39@@ -60,19 +86,19 @@
40 content.pack_start (new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0), true, true, 0);
41
42 // Labels
43- var title = new Gtk.Label (title_text);
44- Utils.apply_text_style_to_label (TextStyle.H1, title);
45-
46- title.set_justify (Gtk.Justification.CENTER);
47- content.pack_start (title, false, true, 0);
48-
49- var subtitle = new Gtk.Label (subtitle_text);
50- Utils.apply_text_style_to_label (TextStyle.H2, subtitle);
51-
52- subtitle.sensitive = false;
53- subtitle.set_justify (Gtk.Justification.CENTER);
54-
55- content.pack_start (subtitle, false, true, 2);
56+ title_label = new Gtk.Label (title_text);
57+ Utils.apply_text_style_to_label (TextStyle.H1, title_label);
58+
59+ title_label.set_justify (Gtk.Justification.CENTER);
60+ content.pack_start (title_label, false, true, 0);
61+
62+ subtitle_label = new Gtk.Label (subtitle_text);
63+ Utils.apply_text_style_to_label (TextStyle.H2, subtitle_label);
64+
65+ subtitle_label.sensitive = false;
66+ subtitle_label.set_justify (Gtk.Justification.CENTER);
67+
68+ content.pack_start (subtitle_label, false, true, 2);
69
70 // Options wrapper
71 this.options = new Gtk.Box (Gtk.Orientation.VERTICAL, 8);

Subscribers

People subscribed via source and target branches