Merge ~adam-collard/maas:clone-websocket-endpoint into maas:master

[Adam Collard]

Add Clone NodeAction, websocket handler

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10644/console
COMMIT: 5119c7cba866440aaa24d9d804cb37dce0349844

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10645/console
COMMIT: b546b716b45864a85526e2a5b4275db7bd10d9b0

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10646/console
COMMIT: 04cdd03d42bf0425e88c564678a226f6d2de5e83

review: Needs Fixing

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10647/console
COMMIT: 4d2fc897e9520e452e2c0cb1b5595575cffe8e86

review: Needs Fixing

[Adam Collard (adam-collard)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 4d2fc897e9520e452e2c0cb1b5595575cffe8e86

review: Approve

[Christian Grabowski (cgrabowski)]

LGTM

review: Approve

[MAAS Lander (maas-lander)]

LANDING
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10651/consoleText

[MAAS Lander (maas-lander)]

LANDING
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10652/consoleText

[MAAS Lander (maas-lander)]

LANDING
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10653/consoleText

[MAAS Lander (maas-lander)]

LANDING
-b clone-websocket-endpoint lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10655/consoleText

diff --git a/src/maasserver/forms/clone.py b/src/maasserver/forms/clone.py
index 105c19a..9590f25 100644
--- a/src/maasserver/forms/clone.py
+++ b/src/maasserver/forms/clone.py
@@ -115,8 +115,12 @@ class CloneForm(forms.Form):
                             )
                             set_form_error(self, "destinations", error)
         if not storage and not interfaces:
-            set_form_error(
-                self, "__all__", "Either storage or interfaces must be true."
+            self.add_error(
+                "__all__",
+                ValidationError(
+                    "Either storage or interfaces must be true.",
+                    code="required",
+                ),
             )
         return cleaned_data
 
diff --git a/src/maasserver/node_action.py b/src/maasserver/node_action.py
index afee1c6..1f810cb 100644
--- a/src/maasserver/node_action.py
+++ b/src/maasserver/node_action.py
@@ -38,6 +38,7 @@ from maasserver.exceptions import (
     NodeActionError,
     StaticIPAddressExhaustion,
 )
+from maasserver.forms.clone import CloneForm
 from maasserver.models import Config, ResourcePool, Tag, Zone
 from maasserver.node_status import is_failed_status, NON_MONITORED_STATUSES
 from maasserver.permissions import NodePermission
@@ -950,7 +951,36 @@ class AddTag(NodeAction):
             self.node.tags.add(t)
 
         self.node.save()
-        return
+
+
+class Clone(NodeAction):
+    """Clone storage/network configuration."""
+
+    name = "clone"
+    display = "Clone"
+    display_sentence = "cloned"
+    actionable_statuses = ALL_STATUSES
+    permission = NodePermission.edit
+    machine_permission = NodePermission.admin
+    for_type = {NODE_TYPE.MACHINE}
+    action_type = NODE_ACTION_TYPE.MISC
+    audit_description = "Cloning from '%s'."
+
+    def get_node_action_audit_description(self, action):
+        return self.audit_description % action.node.hostname
+
+    def _execute(self, destinations=None, storage=False, interfaces=False):
+        source = self.node
+        data = {
+            "source": source,
+            "destinations": destinations,
+            "storage": storage,
+            "interfaces": interfaces,
+        }
+        form = CloneForm(self.user, data=data)
+        if not form.is_valid():
+            raise NodeActionError(form.errors.as_json())
+        form.save()
 
 
 ACTION_CLASSES = (
@@ -970,6 +1000,7 @@ ACTION_CLASSES = (
     Lock,
     Unlock,
     AddTag,
+    Clone,
     SetZone,
     SetPool,
     ImportImages,
diff --git a/src/maasserver/tests/test_node_action.py b/src/maasserver/tests/test_node_action.py
index 6a8a4b5..a47d046 100644
--- a/src/maasserver/tests/test_node_action.py
+++ b/src/maasserver/tests/test_node_action.py
@@ -1,6 +1,7 @@
 # Copyright 2012-2020 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
+import json
 import random
 from unittest.mock import ANY
 
@@ -32,6 +33,7 @@ from maasserver.node_action import (
     Acquire,
     ACTION_CLASSES,
     AddTag,
+    Clone,
     Commission,
     compile_node_actions,
     Delete,
@@ -1772,6 +1774,93 @@ class TestExitRescueModeAction(MAASServerTestCase):
         self.assertThat(node_stop_rescue_mode, MockCalledOnceWith(user))
 
 
+class TestCloneAction(MAASServerTestCase):
+    def test_admin_permission_required(self):
+        user = factory.make_User()
+        request = factory.make_fake_request("/")
+        request.user = user
+        node = factory.make_Node()
+        self.assertFalse(Clone(node, user, request).is_permitted())
+
+    def test_requires_destinations(self):
+        user = factory.make_admin()
+        request = factory.make_fake_request("/")
+        request.user = user
+        source = factory.make_Machine()
+        action = Clone(source, user, request)
+        exception = self.assertRaises(
+            NodeActionError, action.execute, storage=True, interfaces=True
+        )
+        (error,) = exception.args
+        self.assertEqual(
+            json.loads(error)["destinations"],
+            [{"code": "required", "message": "This field is required."}],
+        )
+
+    def test_requires_storage_or_interfaces(self):
+        user = factory.make_admin()
+        request = factory.make_fake_request("/")
+        request.user = user
+        source = factory.make_Machine()
+        destination1 = factory.make_Machine(
+            status=NODE_STATUS.READY,
+            with_boot_disk=False,
+        )
+        action = Clone(source, user, request)
+        exception = self.assertRaises(
+            NodeActionError,
+            action.execute,
+            destinations=[destination1.system_id],
+        )
+        (error,) = exception.args
+        self.assertEqual(
+            json.loads(error)["__all__"],
+            [
+                {
+                    "code": "required",
+                    "message": "Either storage or interfaces must be true.",
+                }
+            ],
+        )
+
+    def test_clone_action_log(self):
+        user = factory.make_admin()
+        request = factory.make_fake_request("/")
+        request.user = user
+        source = factory.make_Machine(with_boot_disk=False)
+        factory.make_PhysicalBlockDevice(
+            node=source, size=8 * 1024 ** 3, name="sda"
+        )
+        factory.make_Interface(node=source, name="eth0")
+        destination1 = factory.make_Machine(
+            status=NODE_STATUS.READY,
+            with_boot_disk=False,
+        )
+        factory.make_PhysicalBlockDevice(
+            node=destination1, size=8 * 1024 ** 3, name="sda"
+        )
+        factory.make_Interface(node=destination1, name="eth0")
+        destination2 = factory.make_Machine(
+            status=NODE_STATUS.FAILED_TESTING,
+            with_boot_disk=False,
+        )
+        factory.make_PhysicalBlockDevice(
+            node=destination2, size=8 * 1024 ** 3, name="sda"
+        )
+        factory.make_Interface(node=destination2, name="eth0")
+
+        action = Clone(source, user, request)
+        action.execute(
+            destinations=[destination1.system_id, destination2.system_id],
+            storage=True,
+            interfaces=True,
+        )
+        audit_event = Event.objects.get(type__level=AUDIT)
+        self.assertEqual(
+            audit_event.description, f"Cloning from '{source.hostname}'."
+        )
+
+
 class TestActionsErrorHandling(MAASServerTestCase):
     """Tests for error handling in actions.
 
diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py
index 78da120..391127b 100644
--- a/src/maasserver/websockets/handlers/tests/test_machine.py
+++ b/src/maasserver/websockets/handlers/tests/test_machine.py
@@ -3,6 +3,7 @@
 
 
 from functools import partial
+import json
 import logging
 from operator import itemgetter
 import random
@@ -3636,6 +3637,43 @@ class TestMachineHandler(MAASServerTestCase):
             node.distro_series, Equals(osystem["releases"][0]["name"])
         )
 
+    def test_action_clone_errors_bundled(self):
+        user = factory.make_admin()
+        node = factory.make_Node()
+
+        handler = MachineHandler(user, {}, None)
+        exc = self.assertRaises(
+            NodeActionError,
+            handler.action,
+            {
+                "system_id": node.system_id,
+                "action": "clone",
+                "extra": {
+                    "storage": False,
+                    "interfaces": False,
+                    "destinations": [],
+                },
+            },
+        )
+        (errors,) = exc.args
+        self.assertEqual(
+            json.loads(errors),
+            {
+                "destinations": [
+                    {
+                        "message": "This field is required.",
+                        "code": "required",
+                    }
+                ],
+                "__all__": [
+                    {
+                        "message": "Either storage or interfaces must be true.",
+                        "code": "required",
+                    }
+                ],
+            },
+        )
+
     def test_create_physical_creates_interface(self):
         user = factory.make_admin()
         node = factory.make_Node(interface=False)