Merge ~adam-collard/maas:clone-tweak into maas:master

[Adam Collard]

Filter destination machines by status up front in CloneForm

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-tweak lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/10307/console
COMMIT: b071a5bc865b86fb90b4860983e8f0459bddbc10

review: Needs Fixing

[Adam Collard (adam-collard)]

jenkins: !test

[MAAS Lander (maas-lander)]

UNIT TESTS
-b clone-tweak lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: b071a5bc865b86fb90b4860983e8f0459bddbc10

review: Approve

[Björn Tillenius (bjornt)]

Hmm. Is there a test that checks this functionality.

It seems that you now changed it not to filter by status, no?

review: Needs Information

[Adam Collard (adam-collard)]

Abandoned change since mutating the field in __init__ is changing it for all instances (the Field is mutable) and therefore better to instantiate the queryset afresh each time.

Unmerged commits

b071a5b... by Adam Collard on 2021-06-23

Filter destination machines by status up front

diff --git a/src/maasserver/forms/clone.py b/src/maasserver/forms/clone.py
index 105c19a..d38a957 100644
--- a/src/maasserver/forms/clone.py
+++ b/src/maasserver/forms/clone.py
@@ -28,7 +28,11 @@ class CloneForm(forms.Form):
     )
 
     destinations = SimpleArrayField(
-        NodeChoiceField(queryset=Machine.objects.all()),
+        NodeChoiceField(
+            queryset=Machine.objects.filter(
+                status__in={NODE_STATUS.READY, NODE_STATUS.FAILED_TESTING}
+            )
+        ),
         label="Destinations",
         min_length=1,
         error_messages={
@@ -58,11 +62,7 @@ class CloneForm(forms.Form):
         self.fields[
             "destinations"
         ].base_field.queryset = Machine.objects.get_nodes(
-            self.user,
-            NodePermission.admin,
-            from_nodes=Machine.objects.filter(
-                status__in={NODE_STATUS.READY, NODE_STATUS.FAILED_TESTING}
-            ),
+            self.user, NodePermission.admin
         )
 
     def clean(self):