MAAS

Merge ~adam-collard/maas:2.8-go-1.10 into maas:2.8

  1. Git
  2. lp:~adam-collard/maas
  3. 2.8-go-1.10
  4. Merge into 2.8
Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 2bba2ac463841fb5a76cb3371de1e366e2718c5f
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas:2.8-go-1.10
Merge into: maas:2.8
Diff against target: 13 lines (+1/-1)
1 file modified
snap/snapcraft.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Alberto Donato (community) Approve
MAAS Lander Needs Fixing
Review via email: mp+400317@code.launchpad.net

Commit message

Use 1.10/stable for go snap to match bionic package.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b 2.8-go-1.10 lp:~adam-collard/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9645/console
COMMIT: 2bba2ac463841fb5a76cb3371de1e366e2718c5f

review: Needs Fixing
Revision history for this message
Adam Collard (adam-collard) wrote :

jenkins: !test

Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b 2.8-go-1.10 lp:~adam-collard/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/9647/consoleText

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml
2index 1634116..e235b0f 100644
3--- a/snap/snapcraft.yaml
4+++ b/snap/snapcraft.yaml
5@@ -224,7 +224,7 @@ parts:
6 plugin: make
7 source: src/machine-resources
8 build-snaps:
9- - go
10+ - go/1.10/stable
11 build-packages:
12 - go-dep
13 artifacts:

Subscribers

People subscribed via source and target branches