Merge ~adam-collard/maas:unskip-num-query-controller-test into maas:master

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: 770342641afc21b58c5411a42d69a5a5cc504959
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/maas:unskip-num-query-controller-test
Merge into: maas:master
Diff against target: 29 lines (+1/-4)
1 file modified
src/maasserver/websockets/handlers/tests/test_controller.py (+1/-4)
Reviewer Review Type Date Requested Status
MAAS Lander Needs Fixing
Alberto Donato (community) Approve
Review via email: mp+395709@code.launchpad.net

Commit message

Un-skip the query count test for controllers

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

LANDING
-b unskip-num-query-controller-test lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8957/consoleText

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b unskip-num-query-controller-test lp:~adam-collard/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8958/console
COMMIT: d77bfaf8c365876dd72f36b229cc7c7e1504a35a

review: Needs Fixing
7703426... by Adam Collard

Lint: remove unused import

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/websockets/handlers/tests/test_controller.py b/src/maasserver/websockets/handlers/tests/test_controller.py
2index 873fff1..5281f75 100644
3--- a/src/maasserver/websockets/handlers/tests/test_controller.py
4+++ b/src/maasserver/websockets/handlers/tests/test_controller.py
5@@ -4,8 +4,6 @@
6 """Tests for `maasserver.websockets.handlers.controller`"""
7
8
9-from unittest import skip
10-
11 from testscenarios import multiply_scenarios
12 from testtools.matchers import ContainsDict, Equals
13
14@@ -117,7 +115,6 @@ class TestControllerHandler(MAASServerTestCase):
15 "Number of queries has changed; make sure this is expected.",
16 )
17
18- @skip("XXX: ltrager 2919-11-29 bug=1854546")
19 def test_get_num_queries_is_the_expected_number(self):
20 owner = factory.make_admin()
21 node = factory.make_RegionRackController(owner=owner)
22@@ -148,7 +145,7 @@ class TestControllerHandler(MAASServerTestCase):
23 # and slowing down the client waiting for the response.
24 self.assertEqual(
25 queries,
26- 36,
27+ 35,
28 "Number of queries has changed; make sure this is expected.",
29 )
30

Subscribers

People subscribed via source and target branches