MAAS

Merge ~adam-collard/maas/+git/maas-release-tools:dont-rerelease into ~maas-committers/maas/+git/maas-release-tools:main

  1. Git
  2. lp:~adam-collard/maas/+git/maas-release-tools
  3. dont-rerelease
  4. Merge into main
Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: ae509e931237a5b70fab823c94fea6ce7a43889d
Merge reported by: Adam Collard
Merged at revision: ff3e2762d33c84d0d7b2a7cd08d48e6e9ffd087a
Proposed branch: ~adam-collard/maas/+git/maas-release-tools:dont-rerelease
Merge into: ~maas-committers/maas/+git/maas-release-tools:main
Diff against target: 20 lines (+6/-3)
1 file modified
maas_release_tools/launchpad.py (+6/-3)
Reviewer Review Type Date Requested Status
Alberto Donato (community) Approve
Review via email: mp+412622@code.launchpad.net

Commit message

Don't try to re-release a milestone that's already released.

Signed-off-by: Adam Collard <email address hidden>

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) wrote :

nice, +1

minor suggestion inline

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/maas_release_tools/launchpad.py b/maas_release_tools/launchpad.py
2index 7ebba34..135a1d3 100644
3--- a/maas_release_tools/launchpad.py
4+++ b/maas_release_tools/launchpad.py
5@@ -69,9 +69,12 @@ class LaunchpadActions:
6 milestone.is_active = False
7 milestone.lp_save()
8
9- self.logger.info(f"releasing milestone {milestone.name}")
10- if not self.dry_run:
11- milestone.createProductRelease(date_released=datetime.utcnow())
12+ if milestone.release is None:
13+ self.logger.info(f"releasing milestone {milestone.name}")
14+ if not self.dry_run:
15+ milestone.createProductRelease(date_released=datetime.utcnow())
16+ else:
17+ self.logger.info(f"milestone {milestone.name} already released")
18
19 def _get_client(
20 self, credentials_file: Optional[Path] = None

Subscribers

People subscribed via source and target branches

to all changes: