Thanks, looks good now, +1!
[7]
358 + def test_get_juju_info_sample_data(self): 359 + """L{get_juju_info} parses realistic data properly."""
I might be nitpicking a bit :), but I'd say never use words like "works", "properly", "as expected", etc. in test docstrings. How about?
""" L{get_juju_info} parses JSON data from the juju_filename file."""
[8]
I don't see a test for when get_juju_info parses a file having multiple API endpoints. Is there one?
« Back to merge proposal
Thanks, looks good now, +1!
[7]
358 + def test_get_ juju_info_ sample_ data(self) :
359 + """L{get_juju_info} parses realistic data properly."""
I might be nitpicking a bit :), but I'd say never use words like
"works", "properly", "as expected", etc. in test docstrings. How about?
""" L{get_juju_info} parses JSON data from the juju_filename file."""
[8]
I don't see a test for when get_juju_info parses a file having
multiple API endpoints. Is there one?