Merge ~adam-collard/django-piston3:tox-descriptions-and-extras into django-piston3:master

Proposed by Adam Collard
Status: Merged
Approved by: Adam Collard
Approved revision: a3e1c5d9aa91b56c75625df048772f57b2f9abec
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~adam-collard/django-piston3:tox-descriptions-and-extras
Merge into: django-piston3:master
Diff against target: 51 lines (+12/-3)
2 files modified
MANIFEST.in (+1/-1)
setup.cfg (+11/-2)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Alberto Donato (community) Approve
Review via email: mp+421956@code.launchpad.net

Commit message

Describe tox environments, use extras for it's purpose

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b tox-descriptions-and-extras lp:~adam-collard/django-piston3/+git/django-piston3 into -b master lp:~maas-committers/django-piston3

STATUS: SUCCESS
COMMIT: 6263876509ef5365fe417508de6e331c9b6ea4aa

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b tox-descriptions-and-extras lp:~adam-collard/django-piston3/+git/django-piston3 into -b master lp:~maas-committers/django-piston3

STATUS: SUCCESS
COMMIT: 89e500da30347ff2112ee4c2f7d79c1042a7423b

review: Approve
dc53578... by Adam Collard

Tox minversion 3 parter

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b tox-descriptions-and-extras lp:~adam-collard/django-piston3/+git/django-piston3 into -b master lp:~maas-committers/django-piston3

STATUS: SUCCESS
COMMIT: dc5357814eb0ad130fb86046523e70cfa31e47d7

review: Approve
369cd68... by Adam Collard

Rename [tox:tox] to [tox]

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b tox-descriptions-and-extras lp:~adam-collard/django-piston3/+git/django-piston3 into -b master lp:~maas-committers/django-piston3

STATUS: SUCCESS
COMMIT: b574c76893d912e6b9207793c3324fe52225a315

review: Approve
7d75894... by Adam Collard

Fix path to MANIFEST.in

98aa98d... by Adam Collard

Speed up lint and format, don't need to install package

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b tox-descriptions-and-extras lp:~adam-collard/django-piston3/+git/django-piston3 into -b master lp:~maas-committers/django-piston3

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/piston-tester/63/consoleText
COMMIT: 98aa98d772b1f15795cb5765ca02131c7da19de1

review: Needs Fixing
5f11494... by Adam Collard

Split [tox] and [tox:tox]

Revision history for this message
Alberto Donato (ack) wrote :

+1

please add a comment that the [tox] section can be dropped once we move to jammy only

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b tox-descriptions-and-extras lp:~adam-collard/django-piston3/+git/django-piston3 into -b master lp:~maas-committers/django-piston3

STATUS: SUCCESS
COMMIT: 5f11494cb3dd723543a327b32f7740588f0362d3

review: Approve
a3e1c5d... by Adam Collard

Add comment

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/MANIFEST.in b/MANIFEST.in
2index dfa3628..c059648 100644
3--- a/MANIFEST.in
4+++ b/MANIFEST.in
5@@ -1,3 +1,3 @@
6 include README.md
7
8-recursive-include piston/templates *
9+recursive-include piston3/templates *
10diff --git a/setup.cfg b/setup.cfg
11index 709ddd0..c428d4a 100644
12--- a/setup.cfg
13+++ b/setup.cfg
14@@ -36,19 +36,26 @@ max-line-length = 80
15 select = C, E, F, W, B, B950
16 ignore = E203, E501, W503
17
18-[tox:tox]
19+# This is needed for Jenkins on focal to self-upgrade, doesn't find it if it's in [tox:tox]
20+[tox]
21 minversion = 3.15
22+
23+[tox:tox]
24 envlist = format, lint, py3-django{22,32}
25
26 [testenv]
27+description = Test package with supported Django versions
28+extras =
29+ testing
30 deps =
31 django22: Django==2.2
32 django32: Django==3.2
33- .[testing]
34 commands =
35 {envbindir}/pytest {posargs}
36
37 [testenv:format]
38+skip_install = true
39+description = Format source code
40 deps =
41 black
42 isort
43@@ -57,6 +64,8 @@ commands =
44 {envbindir}/black -q {[globals]lint_files}
45
46 [testenv:lint]
47+skip_install = true
48+description = Lint source code
49 deps =
50 black
51 flake8

Subscribers

People subscribed via source and target branches

to all changes: