Code review comment for lp:~adam-collard/charms/trusty/swift-storage/add-pause-resume-actions

Revision history for this message
Ryan Beisner (1chb1n) wrote :

RE: amulet tests

Thank you for this work!

Just a couple of things that will make future life easier:

_run_action and _wait_on_action:
Please consider landing these in charmhelpers/contrib/amulet/utils.py, as they will be increasingly-common needs.

_assert_services:
Please consider enhancing the existing validate_unit_process_ids amulet helper to fit the needs here. I think it would be a fairly easy mod. We could do -x on pidof in all cases (or add a bool with default False to "check scripts too" if you want to be safer about it). Then add a boolean postive/negative switch to be able to invert its expectations (like you've done with should_run). fwiw, expect_success (default True) is such a bool name that I've used elsewhere for the same purpose in a different context (rmq wip).

« Back to merge proposal