Merge lp:~acysos-team/partner-contact-management/partner-contact-management-city-6.1 into lp:~partner-contact-core-editors/partner-contact-management/6.1
Status: | Rejected |
---|---|
Rejected by: | Guewen Baconnier @ Camptocamp on 2013-08-30 |
Proposed branch: | lp:~acysos-team/partner-contact-management/partner-contact-management-city-6.1 |
Merge into: | lp:~partner-contact-core-editors/partner-contact-management/6.1 |
Diff against target: |
1383 lines (+1269/-0) 21 files modified
city/__init__.py (+29/-0) city/__openerp__.py (+44/-0) city/city.py (+70/-0) city/city_view.xml (+45/-0) city/company.py (+49/-0) city/company_view.xml (+17/-0) city/country.py (+35/-0) city/country_view.xml (+16/-0) city/i18n/bg.po (+88/-0) city/i18n/ca.po (+94/-0) city/i18n/city.pot (+76/-0) city/i18n/es.po (+76/-0) city/i18n/fi.po (+88/-0) city/i18n/fr.po (+93/-0) city/i18n/fr_BE.po (+85/-0) city/i18n/ru.po (+89/-0) city/i18n/sv.po (+86/-0) city/i18n/vi.po (+89/-0) city/partner.py (+50/-0) city/partner_view.xml (+47/-0) city/security/ir.model.access.csv (+3/-0) |
To merge this branch: | bzr merge lp:~acysos-team/partner-contact-management/partner-contact-management-city-6.1 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guewen Baconnier @ Camptocamp | 2013-04-30 | Disapprove on 2013-08-30 | |
Numérigraphe (community) | functional | Disapprove on 2013-05-02 | |
Review via email:
|
Description of the change
Add module city.
Creates a model for storing cities
Zip code, city, state and country fields are replaced with a location field in partner and partner contact forms.
This module helps to keep homogeneous address data in the database.
- 7. By Ignacio Ibeas (www.acysos.com) on 2013-05-01
-
[FIX] city: spanish translation, websites
- 8. By Ignacio Ibeas (www.acysos.com) on 2013-05-01
-
[FIX] city: change name zipcode
Numérigraphe (numerigraphe) wrote : | # |
Users now have to enter redundent data, which I find is a regression from the former behavior in the trunk extra-addons.
Yes, I see and I have add AGPL-3, but I can't push the new commit.
Extra-trunk city doesn't work.
About enter redundant data, I'm not accord. It's a method to get city like a class, an use in all partners with the same data. Also you can create a module that import all cities, like l10n_es_toponyms from geonames and get all cities and zip of a country.
- 9. By Ignacio Ibeas (www.acysos.com) on 2013-05-02
-
[FIX] city: license added
I see that there are a discussion about this module in 7.0. But here there isn't better_zip, only exist this module, because city of extra-trunk doesn't work properly.
You will approve the merge??
Greetings
Numérigraphe (numerigraphe) wrote : | # |
Wouldn't it be better to fix "city" directly in the extra addons while
better_zip is being worked on?
Then when better_zip is ready, we can probably backport it from v7.0.
Lionel Sausin.
Le 06/05/2013 17:06, Ignacio Ibeas (www.acysos.com) a écrit :
> I see that there are a discussion about this module in 7.0. But here there isn't better_zip, only exist this module, because city of extra-trunk doesn't work properly.
>
> You will approve the merge??
>
> Greetings
OpenERP commiters is deprecated (https:/
I upload in my repositories.
Thank you for your time.
I saw recent discussions on the city / better_zip addons. I guess that another MP has been created for this. Can we close this MP?
> I saw recent discussions on the city / better_zip addons. I guess that another
> MP has been created for this. Can we close this MP?
Here it is: https:/
> > I saw recent discussions on the city / better_zip addons. I guess that
> another
> > MP has been created for this. Can we close this MP?
>
> Here it is: https:/
> management/
The MP I mentioned has been merged, so I put this one as 'rejected'.
Unmerged revisions
- 9. By Ignacio Ibeas (www.acysos.com) on 2013-05-02
-
[FIX] city: license added
- 8. By Ignacio Ibeas (www.acysos.com) on 2013-05-01
-
[FIX] city: change name zipcode
- 7. By Ignacio Ibeas (www.acysos.com) on 2013-05-01
-
[FIX] city: spanish translation, websites
- 6. By Ignacio Ibeas (www.acysos.com) on 2013-04-30
-
[ADD] city: City-Helps to keep Homogeneous address data in the Database
My comments about the trunk branch apply here too : https:/ /code.launchpad .net/~pedro. baeza/partner- contact- management/ city-module/ +merge/ 161837