Merge lp:~acsone-openerp/stock-logistic-warehouse/7.0-port-stock_available_immediately into lp:stock-logistic-warehouse

[Laurent Mignon (Acsone)]

7.0 compliant

[Lionel Sausin - Initiatives/Numérigraphe (ls-initiatives)]

Shouldn't class names use StudlyCaps ?

[Laurent Mignon (Acsone) (lmi)]

> Shouldn't class names use StudlyCaps ?
it's just because in openerp, class names are uppercase with underscrore.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Nice, thanks for the port.

Some deprecated things are still there.

"product_immediately_usable()" Can be removed

<field name="type">.+</field> in views too.

+ "init_xml": [],
+ "demo_xml": [],
+ "update_xml": ["product_view.xml", ],
can be replaced by
  "data": ["product_view.xml",
           ]

[lp:~acsone-openerp/stock-logistic-warehouse/7.0-port-stock_available_immediately]

36. By Laurent Mignon (Acsone) on 2014-01-24

remove remaining deprecated things

[Laurent Mignon (Acsone) (lmi)]

Guewen,

Thanks for the review.

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

LGTM, and works fine.

review: Approve (code review, test.)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM
Thanks for the changes

review: Approve (code review)

[Romain Deheele - Camptocamp (romaindeheele)]

Hello Laurent,

LGTM
Just micro things:
in __init__.py, we could use relative import : from . import product
in product.py, we could use : from openerp.addons import decimal_precision as dp

Thanks,

Romain

[lp:~acsone-openerp/stock-logistic-warehouse/7.0-port-stock_available_immediately]

37. By Laurent Mignon (Acsone) on 2014-02-19

Use relative import in __init__.py and complte module path for others import

[Laurent Mignon (Acsone) (lmi)]

Hi Romain

Thanks for the tips. The changes are done.

lmi

[Romain Deheele - Camptocamp (romaindeheele)]

Thanks Laurent,

Romain

review: Approve (code review and test)

=== modified file 'stock_available_immediately/__init__.py'
--- stock_available_immediately/__init__.py	2012-04-24 08:53:45 +0000
+++ stock_available_immediately/__init__.py	2014-02-19 11:43:52 +0000
@@ -18,4 +18,4 @@
 #
 ##############################################################################
 
-import product
+from . import product

=== modified file 'stock_available_immediately/__openerp__.py'
--- stock_available_immediately/__openerp__.py	2013-02-13 08:46:41 +0000
+++ stock_available_immediately/__openerp__.py	2014-02-19 11:43:52 +0000
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-##############################################################################
+#
 #
 #    Author: Guewen Baconnier
 #    Copyright 2010-2012 Camptocamp SA
@@ -18,24 +18,23 @@
 #    You should have received a copy of the GNU Affero General Public License
 #    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
-##############################################################################
+#
 
 
 {
-	"name" : "Immediately Usable Stock Quantity",
-	"version" : "1.0",
-	"depends" : ["product", "stock", ],
-	"author" : "Camptocamp",
+    "name": "Immediately Usable Stock Quantity",
+    "version": "1.0",
+    "depends": ["product", "stock", ],
+    "author": "Camptocamp",
     "license": "AGPL-3",
-	"description": """
+    "description": """
 Compute the immediately usable stock.
 Immediately usable is computed : Quantity on Hand - Outgoing Stock.
 """,
-	"website" : "http://tinyerp.com/module_account.html",
-	"category" : "Generic Modules/Stock",
-	"init_xml" : [],
-	"demo_xml" : [],
-	"update_xml" : ["product_view.xml", ],
-	"active": False,
-	"installable": False
+    "website": "http://tinyerp.com/module_account.html",
+    "category": "Generic Modules/Stock",
+    "data": ["product_view.xml", 
+             ],
+    "active": False,
+    "installable": True
 }

=== modified file 'stock_available_immediately/product.py'
--- stock_available_immediately/product.py	2012-03-14 15:36:38 +0000
+++ stock_available_immediately/product.py	2014-02-19 11:43:52 +0000
@@ -19,12 +19,12 @@
 #
 ##############################################################################
 
-import decimal_precision as dp
-
-from osv import fields, osv
-
-
-class ProductImmediatelyUsable(osv.osv):
+from openerp.addons import decimal_precision as dp
+
+from openerp.osv import orm, fields
+
+
+class product_immediately_usable(orm.Model):
     """
     Inherit Product in order to add an "immediately usable quantity"
     stock field
@@ -49,7 +49,7 @@
             field_names.append('qty_available')
             field_names.append('outgoing_qty')
 
-        res = super(ProductImmediatelyUsable, self)._product_available(
+        res = super(product_immediately_usable, self)._product_available(
             cr, uid, ids, field_names, arg, context)
 
         if 'immediately_usable_qty' in field_names:
@@ -140,5 +140,3 @@
             help="Quantity of products really available for sale." \
                  "Computed as: Quantity On Hand - Outgoing."),
     }
-
-ProductImmediatelyUsable()

=== modified file 'stock_available_immediately/product_view.xml'
--- stock_available_immediately/product_view.xml	2012-04-24 08:53:45 +0000
+++ stock_available_immediately/product_view.xml	2014-02-19 11:43:52 +0000
@@ -12,8 +12,7 @@
         <record model="ir.ui.view" id="view_normal_stock_active_qty_form">
             <field name="name">product.normal.stock.active.qty.form.inherit</field>
             <field name="model">product.product</field>
-            <field name="type">form</field>
-            <field name="inherit_id" ref="stock.view_normal_stock_property_form"/>
+            <field name="inherit_id" ref="stock.view_normal_procurement_locations_form"/>
             <field name="arch" type="xml">
                 <field name="virtual_available" position="after">
                     <newline/>
@@ -25,7 +24,6 @@
         <record model="ir.ui.view" id="product_product_tree_view">
             <field name="name">product_immediately_usable.product_product_tree_view</field>
             <field name="model">product.product</field>
-            <field name="type">form</field>
             <field name="inherit_id" ref="product.product_product_tree_view"/>
             <field name="arch" type="xml">
                 <data>