Merge lp:~acsone-openerp/openerp-connector/bug-1288187-sbi-unicode into lp:~openerp-connector-core-editors/openerp-connector/7.0

[Stéphane Bidoul (Acsone)]

Fix for jobs with unicode arguments.

Drawback is that it is not backward compatible with existing stored jobs.

What would be a better solution?

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi, the test that you provide success on my side. Was the test failing before you made your change?

review: Needs Information

[Stéphane Bidoul (Acsone) (sbi)]

I attached the test log to the bug.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks for the proposal. I'll try to find alternative ways to fix that.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Here is my first attempt to fix that: https://code.launchpad.net/~camptocamp/openerp-connector/7.0-unicode-pickled-1288187/+merge/209481

I think that using a binary field and avoiding conversions is better since pickled data is binary.
I still have to do some figure and figure out a way to migrate the existing jobs.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Thanks Stéphane for your analysis of the issue and for proposing a patch!

I set this proposal as rejected as you acknowledged mine [0]

[0] https://code.launchpad.net/~camptocamp/openerp-connector/7.0-unicode-pickled-1288187/+merge/209481

Unmerged revisions

621. By Stéphane Bidoul (Acsone) on 2014-03-05

[FIX] jobs with unicode arguments

=== modified file 'connector/queue/job.py'
--- connector/queue/job.py	2014-02-04 14:39:23 +0000
+++ connector/queue/job.py	2014-03-05 11:38:03 +0000
@@ -65,7 +65,7 @@
     raised as `NotReadableJobError`).
     """
     try:
-        unpickled = loads(pickled.encode('utf-8'))
+        unpickled = loads(pickled.decode('base64'))
     except (StandardError, UnpicklingError):
         raise NotReadableJobError('Could not unpickle.', pickled)
     return unpickled
@@ -212,7 +212,7 @@
 
             vals['func'] = dumps((job.func_name,
                                   job.args,
-                                  job.kwargs))
+                                  job.kwargs)).encode('base64')
 
             self.job_model.create(self.session.cr,
                                   SUPERUSER_ID,

=== modified file 'connector/tests/test_job.py'
--- connector/tests/test_job.py	2014-01-13 16:07:35 +0000
+++ connector/tests/test_job.py	2014-03-05 11:38:03 +0000
@@ -127,7 +127,7 @@
         eta = datetime.now() + timedelta(hours=5)
         job = Job(func=dummy_task_args,
                   model_name='res.users',
-                  args=('o', 'k'),
+                  args=(u'oé', 'k'),
                   kwargs={'c': '!'},
                   priority=15,
                   eta=eta,