Code review comment for lp:~acsone-openerp/banking-addons/bank-statement-reconcile-70-improve-acc-number-completion
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Needs Fixing
(code review)
Some things catched on a first sight:
- Use from . import xxx on __init__.py
- 'if len(ids):' could be 'if ids', or better, put 'if not ids:' and put the rest of the code inside, returning only the value at the end, because it makes it more readable.
- Don't use SQL query. You can use also ORM search with like operator.
- Complete tests with calls to this method with more cases: account number without spaces that must be right, account number that must be wrong, so that we can test false positives.
Regards.